Remove desktop.calling.raiseHand flag

ts/RemoteConfig.ts

@@ -17,7 +17,6 @@ import { getCountryCode } from './types/PhoneNumber';
 export type ConfigKeyType =
   | 'desktop.calling.adhoc'
   | 'desktop.calling.adhoc.create'
-  | 'desktop.calling.raiseHand'
   | 'desktop.calling.ringrtcAdm'
   | 'desktop.clientExpiration'
   | 'desktop.backup.credentialFetch'

ts/components/CallManager.stories.tsx

@@ -107,7 +107,6 @@ const createProps = (storyProps: Partial<PropsType> = {}): PropsType => ({
   i18n,
   incomingCall: null,
   callLink: storyProps.callLink ?? undefined,
-  isGroupCallRaiseHandEnabled: true,
   me: {
     ...getDefaultConversation({
       color: AvatarColors[0],

ts/components/CallManager.tsx

@@ -108,7 +108,6 @@ export type PropsType = {
   denyUser: (payload: PendingUserActionPayloadType) => void;
   hasInitialLoadCompleted: boolean;
   i18n: LocalizerType;
-  isGroupCallRaiseHandEnabled: boolean;
   me: ConversationType;
   notifyForCall: (
     conversationId: string,
@@ -176,7 +175,6 @@ function ActiveCallManager({
   denyUser,
   hangUpActiveCall,
   i18n,
-  isGroupCallRaiseHandEnabled,
   getIsSharingPhoneNumberWithEverybody,
   getGroupCallVideoFrameSource,
   getPresentingSources,
@@ -462,7 +460,6 @@ function ActiveCallManager({
         i18n={i18n}
         imageDataCache={imageDataCache}
         isCallLinkAdmin={isCallLinkAdmin}
-        isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled}
         me={me}
         openSystemPreferencesAction={openSystemPreferencesAction}
         renderEmojiPicker={renderEmojiPicker}
@@ -549,7 +546,6 @@ export function CallManager({
   i18n,
   incomingCall,
   isConversationTooBigToRing,
-  isGroupCallRaiseHandEnabled,
   getIsSharingPhoneNumberWithEverybody,
   me,
   notifyForCall,
@@ -645,7 +641,6 @@ export function CallManager({
           getPresentingSources={getPresentingSources}
           hangUpActiveCall={hangUpActiveCall}
           i18n={i18n}
-          isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled}
           getIsSharingPhoneNumberWithEverybody={
             getIsSharingPhoneNumberWithEverybody
           }

ts/components/CallScreen.stories.tsx

@@ -202,7 +202,6 @@ const createProps = (
   i18n,
   imageDataCache: React.createRef<CallingImageDataCache>(),
   isCallLinkAdmin: true,
-  isGroupCallRaiseHandEnabled: true,
   me: getDefaultConversation({
     color: AvatarColors[1],
     id: '6146087e-f7ef-457e-9a8d-47df1fdd6b25',

ts/components/CallScreen.tsx

@@ -104,7 +104,6 @@ export type PropsType = {
   i18n: LocalizerType;
   imageDataCache: React.RefObject<CallingImageDataCache>;
   isCallLinkAdmin: boolean;
-  isGroupCallRaiseHandEnabled: boolean;
   me: ConversationType;
   openSystemPreferencesAction: () => unknown;
   renderReactionPicker: (
@@ -198,7 +197,6 @@ export function CallScreen({
   i18n,
   imageDataCache,
   isCallLinkAdmin,
-  isGroupCallRaiseHandEnabled,
   me,
   openSystemPreferencesAction,
   renderEmojiPicker,
@@ -933,7 +931,7 @@ export function CallScreen({
               onClick={toggleAudio}
               tooltipDirection={TooltipPlacement.Top}
             />
-            {isGroupCallRaiseHandEnabled && raiseHandButtonType && (
+            {raiseHandButtonType && (
               <CallingButton
                 buttonType={raiseHandButtonType}
                 i18n={i18n}

ts/state/smart/CallManager.tsx

@@ -38,7 +38,6 @@ import type { AciString } from '../../types/ServiceId';
 import { strictAssert } from '../../util/assert';
 import { callLinkToConversation } from '../../util/callLinks';
 import { callingTones } from '../../util/callingTones';
-import { isGroupCallRaiseHandEnabled } from '../../util/isGroupCallRaiseHandEnabled';
 import { missingCaseError } from '../../util/missingCaseError';
 import { useAudioPlayerActions } from '../ducks/audioPlayer';
 import { getActiveCall, useCallingActions } from '../ducks/calling';
@@ -496,7 +495,6 @@ export const SmartCallManager = memo(function SmartCallManager() {
       i18n={i18n}
       incomingCall={incomingCall}
       isConversationTooBigToRing={isConversationTooBigToRing}
-      isGroupCallRaiseHandEnabled={isGroupCallRaiseHandEnabled()}
       me={me}
       notifyForCall={notifyForCall}
       openSystemPreferencesAction={openSystemPreferencesAction}

ts/util/isGroupCallRaiseHandEnabled.ts

@@ -1,14 +0,0 @@
-// Copyright 2023 Signal Messenger, LLC
-// SPDX-License-Identifier: AGPL-3.0-only
-
-import * as RemoteConfig from '../RemoteConfig';
-import { isProduction } from './version';
-
-export function isGroupCallRaiseHandEnabled(): boolean {
-  if (!isProduction(window.getVersion())) {
-    return true;
-  }
-
-  // In production, use the config
-  return Boolean(RemoteConfig.isEnabled('desktop.calling.raiseHand'));
-}