mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

getProfiles: Better logging; don't let promise propagate

Browse source
This commit is contained in:
Scott Nonnenberg 2024-03-25 10:03:15 -07:00 • committed by GitHub
parent 83e0e5d33b
commit a39e46db5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 49 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
ts/state/ducks/conversations.ts
View file

@ -2741,7 +2741,11 @@ function getProfilesForConversation(conversationId: string): NoopActionType {
throw new Error('getProfilesForConversation: no conversation found');
}
void conversation.getProfiles();
drop(
conversation.getProfiles().catch(() => {
/* nothing to do here; logging already happened */
})
);
return {
type: 'NOOP',
@ -2765,7 +2769,11 @@ function conversationStoppedByMissingVerification(payload: {
}
// Intentionally not awaiting here
void conversation.getProfiles();
drop(
conversation.getProfiles().catch(() => {
/* nothing to do here; logging already happened */
})
);
});
return {
@ -4274,7 +4282,9 @@ function onConversationOpened(
conversation.throttledGetProfiles !== undefined,
'Conversation model should be initialized'
);
await conversation.throttledGetProfiles();
await conversation.throttledGetProfiles().catch(() => {
/* nothing to do here; logging already happened */
});
}
drop(conversation.updateVerified());