mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Activate speaker view when screensharing, even while in PiP

Browse source
This commit is contained in:
Josh Perez 2021-10-07 14:56:27 -04:00 • committed by GitHub
parent 1f4a3851bf
commit a363c6c0ea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
ts/components/CallingPip.tsx
View file

@ -13,6 +13,7 @@ import {
SetRendererCanvasType,
} from '../state/ducks/calling';
import { missingCaseError } from '../util/missingCaseError';
import { useActivateSpeakerViewOnPresenting } from '../hooks/useActivateSpeakerViewOnPresenting';
enum PositionMode {
BeingDragged,
@ -58,6 +59,7 @@ export type PropsType = {
setLocalPreview: (_: SetLocalPreviewType) => void;
setRendererCanvas: (_: SetRendererCanvasType) => void;
togglePip: () => void;
toggleSpeakerView: () => void;
};
const PIP_HEIGHT = 156;
@ -75,6 +77,7 @@ export const CallingPip = ({
setLocalPreview,
setRendererCanvas,
togglePip,
toggleSpeakerView,
}: PropsType): JSX.Element | null => {
const videoContainerRef = React.useRef<null | HTMLDivElement>(null);
const localVideoRef = React.useRef(null);
@ -86,6 +89,12 @@ export const CallingPip = ({
offsetY: PIP_TOP_MARGIN,
});
useActivateSpeakerViewOnPresenting(
activeCall.remoteParticipants,
activeCall.isInSpeakerView,
toggleSpeakerView
);
React.useEffect(() => {
setLocalPreview({ element: localVideoRef });
}, [setLocalPreview]);