mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

New compose UX for usernames/e164

Browse source 
Co-authored-by: Jamie Kyle <113370520+jamiebuilds-signal@users.noreply.github.com>
This commit is contained in:
Fedor Indutny 2024-02-08 15:19:03 -08:00 • committed by GitHub
parent e69826dcc6
commit a329189489
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
42 changed files with 19223 additions and 142 deletions
Download patch file Download diff file Expand all files Collapse all files

48
ts/components/ConversationList.tsx
View file

@ -26,7 +26,10 @@ import { ContactListItem } from './conversationList/ContactListItem';
import { ContactCheckbox as ContactCheckboxComponent } from './conversationList/ContactCheckbox';
import { PhoneNumberCheckbox as PhoneNumberCheckboxComponent } from './conversationList/PhoneNumberCheckbox';
import { UsernameCheckbox as UsernameCheckboxComponent } from './conversationList/UsernameCheckbox';
import { CreateNewGroupButton } from './conversationList/CreateNewGroupButton';
import {
ComposeStepButton,
Icon as ComposeStepButtonIcon,
} from './conversationList/ComposeStepButton';
import { StartNewConversation as StartNewConversationComponent } from './conversationList/StartNewConversation';
import { SearchResultsLoadingFakeHeader as SearchResultsLoadingFakeHeaderComponent } from './conversationList/SearchResultsLoadingFakeHeader';
import { SearchResultsLoadingFakeRow as SearchResultsLoadingFakeRowComponent } from './conversationList/SearchResultsLoadingFakeRow';
@ -43,6 +46,8 @@ export enum RowType {
UsernameCheckbox = 'UsernameCheckbox',
Conversation = 'Conversation',
CreateNewGroup = 'CreateNewGroup',
FindByUsername = 'FindByUsername',
FindByPhoneNumber = 'FindByPhoneNumber',
Header = 'Header',
MessageSearchResult = 'MessageSearchResult',
SearchResultsLoadingFakeHeader = 'SearchResultsLoadingFakeHeader',
@ -97,6 +102,14 @@ type CreateNewGroupRowType = {
type: RowType.CreateNewGroup;
};
type FindByUsername = {
type: RowType.FindByUsername;
};
type FindByPhoneNumber = {
type: RowType.FindByPhoneNumber;
};
type MessageRowType = {
type: RowType.MessageSearchResult;
messageId: string;
@ -149,6 +162,8 @@ export type Row =
| UsernameCheckboxRowType
| ConversationRowType
| CreateNewGroupRowType
| FindByUsername
| FindByPhoneNumber
| MessageRowType
| HeaderRowType
| SearchResultsLoadingFakeHeaderType
@ -188,6 +203,8 @@ export type PropsType = {
removeConversation: (conversationId: string) => void;
renderMessageSearchResult?: (id: string) => JSX.Element;
showChooseGroupMembers: () => void;
showFindByUsername: () => void;
showFindByPhoneNumber: () => void;
showConversation: ShowConversationType;
} & LookupConversationWithoutServiceIdActionsType;
@ -214,6 +231,8 @@ export function ConversationList({
scrollable = true,
shouldRecomputeRowHeights,
showChooseGroupMembers,
showFindByUsername,
showFindByPhoneNumber,
lookupConversationWithoutServiceId,
showUserNotFoundModal,
setIsFetchingUUID,
@ -235,6 +254,8 @@ export function ConversationList({
case RowType.ContactCheckbox:
case RowType.Contact:
case RowType.CreateNewGroup:
case RowType.FindByUsername:
case RowType.FindByPhoneNumber:
return SELECT_ROW_HEIGHT;
default:
return NORMAL_ROW_HEIGHT;
@ -398,12 +419,31 @@ export function ConversationList({
}
case RowType.CreateNewGroup:
result = (
<CreateNewGroupButton
i18n={i18n}
<ComposeStepButton
icon={ComposeStepButtonIcon.Group}
title={i18n('icu:createNewGroupButton')}
onClick={showChooseGroupMembers}
/>
);
break;
case RowType.FindByUsername:
result = (
<ComposeStepButton
icon={ComposeStepButtonIcon.Username}
title={i18n('icu:LeftPane__compose__findByUsername')}
onClick={showFindByUsername}
/>
);
break;
case RowType.FindByPhoneNumber:
result = (
<ComposeStepButton
icon={ComposeStepButtonIcon.PhoneNumber}
title={i18n('icu:LeftPane__compose__findByPhoneNumber')}
onClick={showFindByPhoneNumber}
/>
);
break;
case RowType.Header: {
const headerText = row.getHeaderText(i18n);
result = (
@ -491,6 +531,8 @@ export function ConversationList({
renderMessageSearchResult,
setIsFetchingUUID,
showChooseGroupMembers,
showFindByUsername,
showFindByPhoneNumber,
showConversation,
showUserNotFoundModal,
theme,