From a0b7539620f57a2b9008d367053d98bfc38ddc63 Mon Sep 17 00:00:00 2001 From: ayumi-signal <143036029+ayumi-signal@users.noreply.github.com> Date: Wed, 16 Oct 2024 10:08:44 -0700 Subject: [PATCH] Fix ErrorModal title --- ts/components/ErrorModal.stories.tsx | 13 ++++++++++++- ts/components/ErrorModal.tsx | 2 +- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/ts/components/ErrorModal.stories.tsx b/ts/components/ErrorModal.stories.tsx index 676f591c40e4..e203802638e5 100644 --- a/ts/components/ErrorModal.stories.tsx +++ b/ts/components/ErrorModal.stories.tsx @@ -17,7 +17,7 @@ const i18n = setupI18n('en', enMessages); const createProps = (overrideProps: Partial = {}): PropsType => ({ buttonVariant: overrideProps.buttonVariant ?? undefined, description: overrideProps.description ?? '', - title: overrideProps.title ?? '', + title: Object.hasOwn(overrideProps, 'title') ? overrideProps.title : '', i18n, onClose: action('onClick'), }); @@ -48,3 +48,14 @@ export function CustomStrings(): JSX.Element { /> ); } + +export function NoTitle(): JSX.Element { + return ( + + ); +} diff --git a/ts/components/ErrorModal.tsx b/ts/components/ErrorModal.tsx index cd964508ca09..b215cea3b173 100644 --- a/ts/components/ErrorModal.tsx +++ b/ts/components/ErrorModal.tsx @@ -40,7 +40,7 @@ export function ErrorModal(props: PropsType): JSX.Element { modalName="ErrorModal" i18n={i18n} onClose={onClose} - title={title == null ? undefined : i18n('icu:ErrorModal--title')} + title={title == null ? undefined : title || i18n('icu:ErrorModal--title')} modalFooter={footer} >