mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Refactor outbound delivery state

Browse source
This commit is contained in:
Evan Hahn 2021-07-09 16:38:51 -05:00 • committed by GitHub
parent 831ec98418
commit 9c48a95eb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 3200 additions and 697 deletions
Download patch file Download diff file Expand all files Collapse all files

59
ts/textsecure/SendMessage.ts
View file

@ -47,7 +47,7 @@ import {
LinkPreviewImage,
LinkPreviewMetadata,
} from '../linkPreviews/linkPreviewFetch';
import { concat } from '../util/iterables';
import { concat, isEmpty, map } from '../util/iterables';
import { SignalService as Proto } from '../protobuf';
export type SendMetadataType = {
@ -996,8 +996,8 @@ export default class MessageSender {
destination,
destinationUuid,
expirationStartTimestamp,
sentTo,
unidentifiedDeliveries,
conversationIdsSentTo = [],
conversationIdsWithSealedSender = new Set(),
isUpdate,
options,
}: {
@ -1006,8 +1006,8 @@ export default class MessageSender {
destination: string | undefined;
destinationUuid: string | null | undefined;
expirationStartTimestamp: number | null;
sentTo?: Array<string>;
unidentifiedDeliveries?: Array<string>;
conversationIdsSentTo?: Iterable<string>;
conversationIdsWithSealedSender?: Set<string>;
isUpdate?: boolean;
options?: SendOptionsType;
}): Promise<CallbackResultType | void> {
@ -1035,38 +1035,33 @@ export default class MessageSender {
sentMessage.expirationStartTimestamp = expirationStartTimestamp;
}
const unidentifiedLookup = (unidentifiedDeliveries || []).reduce(
(accumulator, item) => {
// eslint-disable-next-line no-param-reassign
accumulator[item] = true;
return accumulator;
},
Object.create(null)
);
if (isUpdate) {
sentMessage.isRecipientUpdate = true;
}
// Though this field has 'unidenified' in the name, it should have entries for each
// number we sent to.
if (sentTo && sentTo.length) {
sentMessage.unidentifiedStatus = sentTo.map(identifier => {
const status = new Proto.SyncMessage.Sent.UnidentifiedDeliveryStatus();
const conv = window.ConversationController.get(identifier);
if (conv) {
const e164 = conv.get('e164');
if (e164) {
status.destination = e164;
if (!isEmpty(conversationIdsSentTo)) {
sentMessage.unidentifiedStatus = [
...map(conversationIdsSentTo, conversationId => {
const status = new Proto.SyncMessage.Sent.UnidentifiedDeliveryStatus();
const conv = window.ConversationController.get(conversationId);
if (conv) {
const e164 = conv.get('e164');
if (e164) {
status.destination = e164;
}
const uuid = conv.get('uuid');
if (uuid) {
status.destinationUuid = uuid;
}
}
const uuid = conv.get('uuid');
if (uuid) {
status.destinationUuid = uuid;
}
}
status.unidentified = Boolean(unidentifiedLookup[identifier]);
return status;
});
status.unidentified = conversationIdsWithSealedSender.has(
conversationId
);
return status;
}),
];
}
const syncMessage = this.createSyncMessage();
@ -1687,8 +1682,8 @@ export default class MessageSender {
destination: e164,
destinationUuid: uuid,
expirationStartTimestamp: null,
sentTo: [],
unidentifiedDeliveries: [],
conversationIdsSentTo: [],
conversationIdsWithSealedSender: new Set(),
options,
}).catch(logError('resetSession/sendSync error:'));