Improve error handling during group sends

This commit is contained in:
Fedor Indutny 2022-11-22 10:43:43 -08:00 committed by GitHub
parent f0a3735ca2
commit 991580a1ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
58 changed files with 299 additions and 324 deletions

View file

@ -609,7 +609,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.info(
'User chose not to delete old data. Shutting down.',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
window.shutdown();
return;
@ -627,7 +627,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'Failed to remove IndexedDB file or remove SQL data:',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
@ -859,7 +859,7 @@ export async function startApp(): Promise<void> {
try {
await window.Signal.Data.startInRendererProcess();
} catch (err) {
log.error('SQL failed to initialize', err && err.stack ? err.stack : err);
log.error('SQL failed to initialize', Errors.toLogFormat(err));
}
setAppLoadingScreenMessage(window.i18n('loading'), window.i18n);
@ -950,7 +950,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.warn(
'background/setInterval: Failed to parse integer from desktop.retryRespondMaxAge feature flag',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
@ -961,7 +961,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'background/onready/setInterval: Error deleting sent protos: ',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
@ -991,7 +991,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'background/onready/setInterval: Error getting expired retry placeholders: ',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
}, FIVE_MINUTES);
@ -1038,7 +1038,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'background.js: ConversationController failed to load:',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
} finally {
initializeRedux({ mainWindowStats, menuOptions });
@ -2140,7 +2140,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'connect: Error refreshing remote config:',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
@ -2226,7 +2226,7 @@ export async function startApp(): Promise<void> {
} catch (e) {
log.error(
'Problem with account manager updates after starting new version: ',
e && e.stack ? e.stack : e
Errors.toLogFormat(e)
);
}
}
@ -2239,7 +2239,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'Error: Unable to register for unauthenticated delivery support.',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
}
@ -2270,7 +2270,7 @@ export async function startApp(): Promise<void> {
} catch (error) {
log.error(
'Error: Unable to register our capabilities.',
error && error.stack ? error.stack : error
Errors.toLogFormat(error)
);
}
}
@ -2859,7 +2859,10 @@ export async function startApp(): Promise<void> {
return;
}
} catch (error) {
log.error('respondWithProfileKeyBatcher error', error && error.stack);
log.error(
'respondWithProfileKeyBatcher error',
Errors.toLogFormat(error)
);
}
sender.queueJob('sendProfileKeyUpdate', () =>
@ -3521,7 +3524,7 @@ export async function startApp(): Promise<void> {
log.error(
'unlinkAndDisconnect: Something went wrong clearing ' +
'local configuration',
eraseError && eraseError.stack ? eraseError.stack : eraseError
Errors.toLogFormat(eraseError)
);
} finally {
window.Signal.Util.Registration.markEverDone();