mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Cache GroupFields

Browse source 
Computing GroupFields is costly so cache them instead of doing the
derivation anew on every message.
This commit is contained in:
Fedor Indutny 2021-04-09 11:20:37 -07:00
parent 847cc3e055
commit 9846fb8edf
1 changed files with 25 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
ts/groups.ts
View file

@ -12,6 +12,7 @@ import {
} from 'lodash';
import { ClientZkGroupCipher } from 'zkgroup';
import { v4 as getGuid } from 'uuid';
import LRU from 'lru-cache';
import {
getCredentialsForToday,
GROUP_CREDENTIALS_KEY,
@ -202,6 +203,18 @@ export type GroupV2ChangeType = {
details: Array<GroupV2ChangeDetailType>;
};
export type GroupFields = {
readonly id: ArrayBuffer;
readonly secretParams: ArrayBuffer;
readonly publicParams: ArrayBuffer;
};
const MAX_CACHED_GROUP_FIELDS = 100;
const groupFieldsCache = new LRU<string, GroupFields>({
max: MAX_CACHED_GROUP_FIELDS,
});
const { updateConversation } = dataInterface;
if (!isNumber(MAX_MESSAGE_SCHEMA)) {
@ -1314,18 +1327,26 @@ export function idForLogging(groupId: string | undefined): string {
return `groupv2(${groupId})`;
}
export function deriveGroupFields(
masterKey: ArrayBuffer
): { id: ArrayBuffer; secretParams: ArrayBuffer; publicParams: ArrayBuffer } {
export function deriveGroupFields(masterKey: ArrayBuffer): GroupFields {
const cacheKey = arrayBufferToBase64(masterKey);
const cached = groupFieldsCache.get(cacheKey);
if (cached) {
return cached;
}
window.log.info('deriveGroupFields: cache miss');
const secretParams = deriveGroupSecretParams(masterKey);
const publicParams = deriveGroupPublicParams(secretParams);
const id = deriveGroupID(secretParams);
return {
const fresh = {
id,
secretParams,
publicParams,
};
groupFieldsCache.set(cacheKey, fresh);
return fresh;
}
async function makeRequestWithTemporalRetry<T>({