From 9619e5b66d58faff35e88c87da07bcac42be6725 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Tue, 24 Apr 2018 18:33:10 -0700 Subject: [PATCH] Fix quote thumbnail flickering issue Turns out that we reload thumbnails for every message when any new message is added to the conversation. This fix prevents that by actually checking for the proper sentinel on the message model --- js/models/conversations.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/models/conversations.js b/js/models/conversations.js index c5c3a4cb9f..03182f3c8c 100644 --- a/js/models/conversations.js +++ b/js/models/conversations.js @@ -1250,7 +1250,7 @@ // If we already have a quoted message, then we exit early. If we don't have it, // then we'll continue to look again for an in-memory message to use. Why? This // will enable us to scroll to it when the user clicks. - if (messages.quotedMessage) { + if (message.quotedMessage) { return; }