getAllStories: Remove nested queries

ts/test-electron/sql/stories_test.ts

@@ -137,5 +137,114 @@ describe('sql/stories', () => {
         'storiesByAuthor last should be story2'
       );
     });
+
+    it('populates hasReplies and hasRepliesFromSelf', async () => {
+      assert.lengthOf(await _getAllMessages(), 0);
+
+      const now = Date.now();
+      const conversationId = generateUuid();
+      const sourceServiceId = generateAci();
+      const ourAci = generateAci();
+      const storyId1 = generateUuid();
+      const storyId2 = generateUuid();
+
+      const story1: MessageAttributesType = {
+        id: storyId1,
+        body: 'story 1',
+        type: 'story',
+        conversationId,
+        sent_at: now - 20,
+        received_at: now - 20,
+        timestamp: now - 20,
+        sourceServiceId: generateAci(),
+      };
+      const story2: MessageAttributesType = {
+        id: storyId2,
+        body: 'story 2',
+        type: 'story',
+        conversationId: generateUuid(),
+        sent_at: now - 10,
+        received_at: now - 10,
+        timestamp: now - 10,
+        sourceServiceId,
+      };
+      const story3: MessageAttributesType = {
+        id: generateUuid(),
+        body: 'story 3',
+        type: 'story',
+        conversationId: generateUuid(),
+        sent_at: now,
+        received_at: now,
+        timestamp: now,
+        sourceServiceId,
+      };
+      const replyTo1: MessageAttributesType = {
+        id: generateUuid(),
+        body: 'message 3',
+        type: 'incoming',
+        storyId: storyId1,
+        conversationId: generateUuid(),
+        sent_at: now,
+        received_at: now,
+        timestamp: now,
+        sourceServiceId,
+      };
+      const replyFromSelfTo1: MessageAttributesType = {
+        id: generateUuid(),
+        body: 'story 4',
+        type: 'outgoing',
+        storyId: storyId1,
+        conversationId,
+        sent_at: now,
+        received_at: now,
+        timestamp: now,
+        sourceServiceId: generateAci(),
+      };
+      const replyTo2: MessageAttributesType = {
+        id: generateUuid(),
+        body: 'story 5',
+        type: 'incoming',
+        storyId: storyId2,
+        conversationId: generateUuid(),
+        sent_at: now,
+        received_at: now,
+        timestamp: now,
+        sourceServiceId,
+      };
+
+      await saveMessages(
+        [story1, story2, story3, replyTo1, replyFromSelfTo1, replyTo2],
+        {
+          forceSave: true,
+          ourAci,
+        }
+      );
+
+      assert.lengthOf(await _getAllMessages(), 6);
+
+      const stories = await getAllStories({});
+      assert.lengthOf(stories, 3, 'expect three total stories');
+
+      // They are in ASC order
+      assert.strictEqual(
+        stories[0].id,
+        story1.id,
+        'stories first should be story1'
+      );
+      assert.strictEqual(
+        stories[2].id,
+        story3.id,
+        'stories last should be story3'
+      );
+
+      assert.strictEqual(stories[0].hasReplies, true);
+      assert.strictEqual(stories[0].hasRepliesFromSelf, true);
+
+      assert.strictEqual(stories[1].hasReplies, true);
+      assert.strictEqual(stories[1].hasRepliesFromSelf, false);
+
+      assert.strictEqual(stories[2].hasReplies, false);
+      assert.strictEqual(stories[2].hasRepliesFromSelf, false);
+    });
   });
 });