mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Override environment vars in production

Browse source 
Don't allow environment vars to muck with configs in production.

// FREEBIE
This commit is contained in:
lilia 2017-04-13 12:34:52 -07:00 • committed by Scott Nonnenberg
parent 14b65a9dce
commit 934d06b512
No known key found for this signature in database
GPG key ID: A4931C09644C654B
1 changed files with 21 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

21
main.js
View file

@ -32,7 +32,28 @@ const environment = package_json.environment || process.env.NODE_ENV || 'develop
// Set environment vars to configure node-config before requiring it // Set environment vars to configure node-config before requiring it
process.env.NODE_ENV = environment; process.env.NODE_ENV = environment;
process.env.NODE_CONFIG_DIR = path.join(__dirname, 'config'); process.env.NODE_CONFIG_DIR = path.join(__dirname, 'config');
if (environment === 'production') {
// harden production config against the local env
process.env.NODE_CONFIG = '';
process.env.NODE_CONFIG_STRICT_MODE = true;
process.env.HOSTNAME = '';
process.env.NODE_APP_INSTANCE = '';
process.env.ALLOW_CONFIG_MUTATIONS = '';
process.env.SUPPRESS_NO_CONFIG_WARNING = '';
}
const config = require('config'); const config = require('config');
// Log resulting env vars in use by config
[
'NODE_ENV',
'NODE_CONFIG_DIR',
'NODE_CONFIG',
'ALLOW_CONFIG_MUTATIONS',
'HOSTNAME',
'NODE_APP_INSTANCE',
'SUPPRESS_NO_CONFIG_WARNING'
].forEach(function(s) {
console.log(s + ' ' + config.util.getEnv(s));
});
// use a separate data directory for development // use a separate data directory for development
if (config.has('storageProfile')) { if (config.has('storageProfile')) {