From 9204188aa352da7126848f0a1e99a1dca2fd534e Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Wed, 14 Jun 2017 10:38:33 -0700 Subject: [PATCH] A bit of cleanup after some early code review FREEBIE --- js/views/conversation_view.js | 3 +-- js/views/group_member_list_view.js | 6 +----- stylesheets/_global.scss | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/js/views/conversation_view.js b/js/views/conversation_view.js index 792887c020f9..016233b3d4fb 100644 --- a/js/views/conversation_view.js +++ b/js/views/conversation_view.js @@ -120,7 +120,6 @@ model: this.model }); this.titleView.render(); - this.titleView.render(); this.view = new Whisper.MessageListView({ collection: this.model.messageCollection, @@ -573,7 +572,7 @@ var view = new Whisper.GroupMemberList({ model: members, - // we pass this in to allow nexted panels + // we pass this in to allow nested panels listenBack: this.listenBack.bind(this) }); diff --git a/js/views/group_member_list_view.js b/js/views/group_member_list_view.js index 9010068834bb..ff4337dc4e57 100644 --- a/js/views/group_member_list_view.js +++ b/js/views/group_member_list_view.js @@ -5,11 +5,7 @@ 'use strict'; window.Whisper = window.Whisper || {}; - // This needs to make each member link to their verification view - except for yourself - // Do we update the display of each user to add Verified to their name if verified? - // What about the case where we're brought here because there are multiple users in the no-longer-verified state? - // We probably want to display some sort of helper text in that case at the least - // Or do we show only the problematic users in that case? + // TODO: take a title string which could replace the 'members' header Whisper.GroupMemberList = Whisper.View.extend({ className: 'group-member-list panel', templateName: 'group-member-list', diff --git a/stylesheets/_global.scss b/stylesheets/_global.scss index 4982bce5e719..b1bbd840b117 100644 --- a/stylesheets/_global.scss +++ b/stylesheets/_global.scss @@ -336,7 +336,6 @@ $avatar-size: 44px; } .banner { - // maybe make the top offset smaller here, or smaller in the iOS theme? // what's the right color? background-color: orange; color: black;