mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Prefer type to interface and add an ESLint rule

Browse source
This commit is contained in:
Evan Hahn 2021-01-14 12:07:05 -06:00 • committed by Scott Nonnenberg
parent c85c073669
commit 8a72607fa7
106 changed files with 431 additions and 375 deletions
Download patch file Download diff file Expand all files Collapse all files

32
ts/state/ducks/calling.ts
View file

@ -30,24 +30,24 @@ import { LatestQueue } from '../../util/LatestQueue';
// State
export interface GroupCallPeekInfoType {
export type GroupCallPeekInfoType = {
uuids: Array<string>;
creatorUuid?: string;
eraId?: string;
maxDevices: number;
deviceCount: number;
}
};
export interface GroupCallParticipantInfoType {
export type GroupCallParticipantInfoType = {
uuid: string;
demuxId: number;
hasRemoteAudio: boolean;
hasRemoteVideo: boolean;
speakerTime?: number;
videoAspectRatio: number;
}
};
export interface DirectCallStateType {
export type DirectCallStateType = {
callMode: CallMode.Direct;
conversationId: string;
callState?: CallState;
@ -55,18 +55,18 @@ export interface DirectCallStateType {
isIncoming: boolean;
isVideoCall: boolean;
hasRemoteVideo?: boolean;
}
};
export interface GroupCallStateType {
export type GroupCallStateType = {
callMode: CallMode.Group;
conversationId: string;
connectionState: GroupCallConnectionState;
joinState: GroupCallJoinState;
peekInfo: GroupCallPeekInfoType;
remoteParticipants: Array<GroupCallParticipantInfoType>;
}
};
export interface ActiveCallStateType {
export type ActiveCallStateType = {
conversationId: string;
hasLocalAudio: boolean;
hasLocalVideo: boolean;
@ -76,11 +76,11 @@ export interface ActiveCallStateType {
safetyNumberChangedUuids: Array<string>;
settingsDialogOpen: boolean;
showParticipantsList: boolean;
}
};
export interface CallsByConversationType {
export type CallsByConversationType = {
[conversationId: string]: DirectCallStateType | GroupCallStateType;
}
};
export type CallingStateType = MediaDeviceSettings & {
callsByConversation: CallsByConversationType;
@ -145,15 +145,15 @@ type PeekNotConnectedGroupCallType = {
conversationId: string;
};
interface StartDirectCallType {
type StartDirectCallType = {
conversationId: string;
hasLocalAudio: boolean;
hasLocalVideo: boolean;
}
};
export interface StartCallType extends StartDirectCallType {
export type StartCallType = StartDirectCallType & {
callMode: CallMode.Direct | CallMode.Group;
}
};
export type RemoteVideoChangeType = {
conversationId: string;