mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Prefer type to interface and add an ESLint rule

Browse source
This commit is contained in:
Evan Hahn 2021-01-14 12:07:05 -06:00 • committed by Scott Nonnenberg
parent c85c073669
commit 8a72607fa7
106 changed files with 431 additions and 375 deletions
Download patch file Download diff file Expand all files Collapse all files

16
ts/components/conversation/Quote.tsx
View file

@ -13,7 +13,7 @@ import { ColorType } from '../../types/Colors';
import { ContactName } from './ContactName';
import { getTextWithMentions } from '../../util/getTextWithMentions';
export interface Props {
export type Props = {
attachment?: QuotedAttachmentType;
authorTitle: string;
authorPhoneNumber?: string;
@ -29,25 +29,25 @@ export interface Props {
onClose?: () => void;
text: string;
referencedMessageNotFound: boolean;
}
};
interface State {
type State = {
imageBroken: boolean;
}
};
export interface QuotedAttachmentType {
export type QuotedAttachmentType = {
contentType: MIME.MIMEType;
fileName: string;
/** Not included in protobuf */
isVoiceMessage: boolean;
thumbnail?: Attachment;
}
};
interface Attachment {
type Attachment = {
contentType: MIME.MIMEType;
/** Not included in protobuf, and is loaded asynchronously */
objectUrl?: string;
}
};
function validateQuote(quote: Props): boolean {
if (quote.text) {