mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Prefer type to interface and add an ESLint rule

Browse source
This commit is contained in:
Evan Hahn 2021-01-14 12:07:05 -06:00 • committed by Scott Nonnenberg
parent c85c073669
commit 8a72607fa7
106 changed files with 431 additions and 375 deletions
Download patch file Download diff file Expand all files Collapse all files

20
ts/components/LeftPane.tsx
View file

@ -17,7 +17,7 @@ import {
import { LocalizerType } from '../types/Util';
import { cleanId } from './_util';
export interface PropsType {
export type PropsType = {
conversations?: Array<ConversationListItemPropsType>;
archivedConversations?: Array<ConversationListItemPropsType>;
pinnedConversations?: Array<ConversationListItemPropsType>;
@ -43,7 +43,7 @@ export interface PropsType {
renderNetworkStatus: () => JSX.Element;
renderRelinkDialog: () => JSX.Element;
renderUpdateDialog: () => JSX.Element;
}
};
// from https://github.com/bvaughn/react-virtualized/blob/fb3484ed5dcc41bffae8eab029126c0fb8f7abc0/source/List/types.js#L5
type RowRendererParamsType = {
@ -69,26 +69,26 @@ export enum HeaderType {
Chats,
}
interface ArchiveButtonRow {
type ArchiveButtonRow = {
type: RowType.ArchiveButton;
}
};
interface ConversationRow {
type ConversationRow = {
index: number;
type:
| RowType.ArchivedConversation
| RowType.Conversation
| RowType.PinnedConversation;
}
};
interface HeaderRow {
type HeaderRow = {
headerType: HeaderType;
type: RowType.Header;
}
};
interface UndefinedRow {
type UndefinedRow = {
type: RowType.Undefined;
}
};
type Row = ArchiveButtonRow | ConversationRow | HeaderRow | UndefinedRow;