mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not generate notification when disabled

Browse source 
Generating identicons for notifications is costly even if they are
cached. Avoid this extra load when notifications are not going to be
shown anyway.
This commit is contained in:
Fedor Indutny 2021-04-09 08:52:31 -07:00 committed by Josh Perez
parent 23b3d34eef
commit 847cc3e055
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ts/models/conversations.ts
View file

@ -5066,6 +5066,12 @@ export class ConversationModel extends window.Backbone.Model<
} }
async notify(message: WhatIsThis, reaction?: WhatIsThis): Promise<void> { async notify(message: WhatIsThis, reaction?: WhatIsThis): Promise<void> {
// As a performance optimization don't perform any work if notifications are
// disabled.
if (!window.Whisper.Notifications.isEnabled) {
return;
}
if (this.isMuted()) { if (this.isMuted()) {
return; return;
} }

1
ts/window.d.ts vendored
View file

@ -708,6 +708,7 @@ export type WhisperType = {
BodyRangeType: BodyRangeType; BodyRangeType: BodyRangeType;
Notifications: { Notifications: {
isEnabled: boolean;
removeBy: (filter: Partial<unknown>) => void; removeBy: (filter: Partial<unknown>) => void;
add: (notification: unknown) => void; add: (notification: unknown) => void;
clear: () => void; clear: () => void;