Add additional logging for attachment downloading

This commit is contained in:
trevor-signal 2024-03-20 11:23:31 -04:00 committed by GitHub
parent 62e33b44ba
commit 83e8f4b59d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 26 additions and 1 deletions

View file

@ -221,6 +221,7 @@ async function _maybeStartJob(): Promise<void> {
const logId = `attachment_downloads/_maybeStartJob/postProcess/${job.id}`; const logId = `attachment_downloads/_maybeStartJob/postProcess/${job.id}`;
try { try {
await promise; await promise;
log.info(`${logId}: job has finished running`);
if (_activeAttachmentDownloadJobs[job.id]) { if (_activeAttachmentDownloadJobs[job.id]) {
throw new Error( throw new Error(
`${logId}: Active attachments jobs list still has this job!` `${logId}: Active attachments jobs list still has this job!`
@ -341,6 +342,10 @@ async function _runJob(job?: AttachmentDownloadJobType): Promise<void> {
return; return;
} }
logger.info(
`attachment_downloads/_runJob(${id}): processing new attachment` +
` of type: ${type}`
);
const upgradedAttachment = const upgradedAttachment =
await window.Signal.Migrations.processNewAttachment(downloaded); await window.Signal.Migrations.processNewAttachment(downloaded);
@ -470,6 +475,10 @@ async function _finishJob(
await saveMessage(message.attributes, { await saveMessage(message.attributes, {
ourAci: window.textsecure.storage.user.getCheckedAci(), ourAci: window.textsecure.storage.user.getCheckedAci(),
}); });
} else {
logger.info(
`attachment_downloads/_finishJob for job id: ${id} without message`
);
} }
await removeAttachmentDownloadJob(id); await removeAttachmentDownloadJob(id);
@ -516,6 +525,8 @@ async function _addAttachmentToMessage(
const logPrefix = `${message.idForLogging()} (type: ${type}, index: ${index})`; const logPrefix = `${message.idForLogging()} (type: ${type}, index: ${index})`;
const attachmentSignature = getAttachmentSignature(attachment); const attachmentSignature = getAttachmentSignature(attachment);
log.info(`${logPrefix}: _addAttachmentToMessage: starting`);
if (type === 'long-message') { if (type === 'long-message') {
let handledAnywhere = false; let handledAnywhere = false;
let attachmentData: Uint8Array | undefined; let attachmentData: Uint8Array | undefined;
@ -601,6 +612,7 @@ async function _addAttachmentToMessage(
`${logPrefix}: Long message attachment found no matching place to apply` `${logPrefix}: Long message attachment found no matching place to apply`
); );
} }
log.info(`${logPrefix}: _addAttachmentToMessage finished`);
} }
return; return;
} }

View file

@ -100,8 +100,11 @@ export async function downloadAttachmentV2(
dropNull(cdnNumber), dropNull(cdnNumber),
options options
); );
log.info(`${logId} got download stream`);
const cipherTextRelativePath = await downloadToDisk({ downloadStream, size }); const cipherTextRelativePath = await downloadToDisk({ downloadStream, size });
log.info(`${logId} downloaded encrypted file to disk`);
const cipherTextAbsolutePath = const cipherTextAbsolutePath =
window.Signal.Migrations.getAbsoluteAttachmentPath(cipherTextRelativePath); window.Signal.Migrations.getAbsoluteAttachmentPath(cipherTextRelativePath);
@ -112,6 +115,7 @@ export async function downloadAttachmentV2(
size, size,
theirDigest: Bytes.fromBase64(digest), theirDigest: Bytes.fromBase64(digest),
}); });
log.info(`${logId} successfully decrypted`);
safeUnlinkSync(cipherTextAbsolutePath); safeUnlinkSync(cipherTextAbsolutePath);

View file

@ -413,15 +413,19 @@ export async function captureDimensionsAndScreenshot(
if (!attachment.path) { if (!attachment.path) {
return attachment; return attachment;
} }
logger.info('captureDimensionsAndScreenshot: starting');
const absolutePath = getAbsoluteAttachmentPath(attachment.path); const absolutePath = getAbsoluteAttachmentPath(attachment.path);
if (GoogleChrome.isImageTypeSupported(contentType)) { if (GoogleChrome.isImageTypeSupported(contentType)) {
try { try {
logger.info('captureDimensionsAndScreenshot: getting image dimensions');
const { width, height } = await getImageDimensionsFromURL({ const { width, height } = await getImageDimensionsFromURL({
objectUrl: absolutePath, objectUrl: absolutePath,
logger, logger,
}); });
logger.info('captureDimensionsAndScreenshot: generating thumbnail');
const thumbnailBuffer = await blobToArrayBuffer( const thumbnailBuffer = await blobToArrayBuffer(
await makeImageThumbnail({ await makeImageThumbnail({
size: THUMBNAIL_SIZE, size: THUMBNAIL_SIZE,
@ -430,7 +434,7 @@ export async function captureDimensionsAndScreenshot(
logger, logger,
}) })
); );
logger.info('captureDimensionsAndScreenshot: writing thumbnail');
const thumbnailPath = await writeNewAttachmentData( const thumbnailPath = await writeNewAttachmentData(
new Uint8Array(thumbnailBuffer) new Uint8Array(thumbnailBuffer)
); );
@ -457,6 +461,7 @@ export async function captureDimensionsAndScreenshot(
let screenshotObjectUrl: string | undefined; let screenshotObjectUrl: string | undefined;
try { try {
logger.info('captureDimensionsAndScreenshot: making video screenshot');
const screenshotBuffer = await blobToArrayBuffer( const screenshotBuffer = await blobToArrayBuffer(
await makeVideoScreenshot({ await makeVideoScreenshot({
objectUrl: absolutePath, objectUrl: absolutePath,
@ -468,14 +473,17 @@ export async function captureDimensionsAndScreenshot(
screenshotBuffer, screenshotBuffer,
THUMBNAIL_CONTENT_TYPE THUMBNAIL_CONTENT_TYPE
); );
logger.info('captureDimensionsAndScreenshot: getting image dimensions');
const { width, height } = await getImageDimensionsFromURL({ const { width, height } = await getImageDimensionsFromURL({
objectUrl: screenshotObjectUrl, objectUrl: screenshotObjectUrl,
logger, logger,
}); });
logger.info('captureDimensionsAndScreenshot: writing attachment data');
const screenshotPath = await writeNewAttachmentData( const screenshotPath = await writeNewAttachmentData(
new Uint8Array(screenshotBuffer) new Uint8Array(screenshotBuffer)
); );
logger.info('captureDimensionsAndScreenshot: making thumbnail');
const thumbnailBuffer = await blobToArrayBuffer( const thumbnailBuffer = await blobToArrayBuffer(
await makeImageThumbnail({ await makeImageThumbnail({
size: THUMBNAIL_SIZE, size: THUMBNAIL_SIZE,
@ -485,6 +493,7 @@ export async function captureDimensionsAndScreenshot(
}) })
); );
logger.info('captureDimensionsAndScreenshot: writing thumbnail');
const thumbnailPath = await writeNewAttachmentData( const thumbnailPath = await writeNewAttachmentData(
new Uint8Array(thumbnailBuffer) new Uint8Array(thumbnailBuffer)
); );