mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Disable crash reporting in production

Browse source
This commit is contained in:
trevor-signal 2024-05-02 15:52:53 -04:00 committed by GitHub
parent 1e8047cf73
commit 80bc63bb90
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 25 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
app/crashReports.ts
View file

@ -9,6 +9,7 @@ import z from 'zod';
import type { LoggerType } from '../ts/types/Logging';
import * as Errors from '../ts/types/errors';
import { isProduction } from '../ts/util/version';
import OS from '../ts/util/os/osMain';
const dumpSchema = z
@ -64,12 +65,21 @@ async function eraseDumps(
export function setup(
getLogger: () => LoggerType,
showDebugLogWindow: () => Promise<void>
showDebugLogWindow: () => Promise<void>,
forceEnable = false
): void {
getLogger().info('crashReporter: enabled');
crashReporter.start({ uploadToServer: false });
const isEnabled = !isProduction(app.getVersion()) || forceEnable;
if (isEnabled) {
getLogger().info(`crashReporter: ${forceEnable ? 'force ' : ''}enabled`);
crashReporter.start({ uploadToServer: false });
}
ipc.handle('crash-reports:get-count', async () => {
if (!isEnabled) {
return 0;
}
const pendingDumps = await getPendingDumps();
if (pendingDumps.length !== 0) {
getLogger().warn(
@ -80,6 +90,10 @@ export function setup(
});
ipc.handle('crash-reports:write-to-log', async () => {
if (!isEnabled) {
return;
}
const pendingDumps = await getPendingDumps();
if (pendingDumps.length === 0) {
return;
@ -119,6 +133,10 @@ export function setup(
});
ipc.handle('crash-reports:erase', async () => {
if (!isEnabled) {
return;
}
const pendingDumps = await getPendingDumps();
await eraseDumps(getLogger(), pendingDumps);

5
app/main.ts
View file

@ -208,10 +208,13 @@ const DISABLE_GPU =
OS.isLinux() && !process.argv.some(arg => arg === '--enable-gpu');
const DISABLE_IPV6 = process.argv.some(arg => arg === '--disable-ipv6');
const FORCE_ENABLE_CRASH_REPORTS = process.argv.some(
arg => arg === '--enable-crash-reports'
);
const CLI_LANG = cliOptions.lang as string | undefined;
setupCrashReports(getLogger, showDebugLogWindow);
setupCrashReports(getLogger, showDebugLogWindow, FORCE_ENABLE_CRASH_REPORTS);
let sendDummyKeystroke: undefined | (() => void);
if (OS.isWindows()) {