Fix rendering of long names in <DeliveryIssueNotification>

This commit is contained in:
Evan Hahn 2021-09-02 12:34:00 -05:00 committed by GitHub
parent c7b7a355ba
commit 808ade2a8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 51 additions and 33 deletions

View file

@ -10,12 +10,15 @@ import enMessages from '../../../_locales/en/messages.json';
import { DeliveryIssueNotification } from './DeliveryIssueNotification'; import { DeliveryIssueNotification } from './DeliveryIssueNotification';
import { getDefaultConversation } from '../../test-both/helpers/getDefaultConversation'; import { getDefaultConversation } from '../../test-both/helpers/getDefaultConversation';
const story = storiesOf(
'Components/Conversation/DeliveryIssueNotification',
module
);
const i18n = setupI18n('en', enMessages); const i18n = setupI18n('en', enMessages);
const sender = getDefaultConversation(); const sender = getDefaultConversation();
storiesOf('Components/Conversation/DeliveryIssueNotification', module).add( story.add('Default', () => {
'Default',
() => {
return ( return (
<DeliveryIssueNotification <DeliveryIssueNotification
i18n={i18n} i18n={i18n}
@ -24,12 +27,26 @@ storiesOf('Components/Conversation/DeliveryIssueNotification', module).add(
sender={sender} sender={sender}
/> />
); );
} });
);
storiesOf('Components/Conversation/DeliveryIssueNotification', module).add( story.add('With a long name', () => {
'In Group', const longName = '🤷🏽‍♀️❤️🐞'.repeat(50);
() => { return (
<DeliveryIssueNotification
i18n={i18n}
inGroup={false}
learnMoreAboutDeliveryIssue={action('learnMoreAboutDeliveryIssue')}
sender={getDefaultConversation({
firstName: longName,
name: longName,
profileName: longName,
title: longName,
})}
/>
);
});
story.add('In Group', () => {
return ( return (
<DeliveryIssueNotification <DeliveryIssueNotification
i18n={i18n} i18n={i18n}
@ -38,5 +55,4 @@ storiesOf('Components/Conversation/DeliveryIssueNotification', module).add(
sender={sender} sender={sender}
/> />
); );
} });
);

View file

@ -49,6 +49,7 @@ export function DeliveryIssueNotification(
<div className="SystemMessage SystemMessage--multiline"> <div className="SystemMessage SystemMessage--multiline">
<div className="SystemMessage__line"> <div className="SystemMessage__line">
<span className="SystemMessage__icon SystemMessage__icon--info" /> <span className="SystemMessage__icon SystemMessage__icon--info" />
<span>
<Intl <Intl
id="DeliveryIssue--notification" id="DeliveryIssue--notification"
components={{ components={{
@ -56,6 +57,7 @@ export function DeliveryIssueNotification(
}} }}
i18n={i18n} i18n={i18n}
/> />
</span>
</div> </div>
<div className="SystemMessage__line"> <div className="SystemMessage__line">
<Button <Button