mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Run orphaned attachment cleanup after timeout

Browse source
This commit is contained in:
Fedor Indutny 2024-08-02 12:46:29 -07:00 committed by GitHub
parent 81bed5c444
commit 7c449dcfed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 30 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
ts/util/encryptLegacyAttachment.ts
View file

@ -8,9 +8,17 @@ import type {
LocalAttachmentV2Type,
} from '../types/Attachment';
import * as log from '../logging/log';
import { DataWriter } from '../sql/Client';
import { AttachmentDisposition } from './getLocalAttachmentUrl';
import { drop } from './drop';
import { MINUTE } from './durations';
let setCheck = false;
let orphanedCount = 0;
let cleanupTimeout: NodeJS.Timeout | undefined;
// Max number of orphaned attachments before we schedule a cleanup.
const MAX_ORPHANED_COUNT = 10000;
const lru = new LRU<string, Promise<LocalAttachmentV2Type>>({
max: 1000,
@ -70,11 +78,32 @@ async function doEncrypt<T extends Partial<AddressableAttachmentType>>(
const data = await readAttachmentData(attachment);
const result = await writeNewAttachmentData(data);
orphanedCount += 1;
// Remove fully migrated attachments without references on next startup.
if (!setCheck) {
if (orphanedCount > MAX_ORPHANED_COUNT) {
log.error('encryptLegacyAttachment: too many orphaned, cleanup now');
if (cleanupTimeout !== undefined) {
clearTimeout(cleanupTimeout);
cleanupTimeout = undefined;
}
cleanup();
} else if (!setCheck) {
setCheck = true;
await window.storage.put('needOrphanedAttachmentCheck', true);
log.error('encryptLegacyAttachment: scheduling orphaned cleanup');
cleanupTimeout = setTimeout(cleanup, 15 * MINUTE);
}
return result;
}
function cleanup(): void {
log.error('encryptLegacyAttachment: running orphaned cleanup');
cleanupTimeout = undefined;
setCheck = false;
orphanedCount = 0;
drop(window.storage.remove('needOrphanedAttachmentCheck'));
drop(DataWriter.cleanupOrphanedAttachments());
}