mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

File protocol filter: log when non-absolute path is rejected

Browse source
This commit is contained in:
Scott Nonnenberg 2018-05-30 18:11:59 -07:00
parent 71d873ccfe
commit 7c3325f55e
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/protocol_filter.js
View file

@ -26,11 +26,12 @@ function _createFileHandler({ userDataPath, installPath, isWindows }) {
const target = path.normalize(_urlToPath(request.url, { isWindows })); const target = path.normalize(_urlToPath(request.url, { isWindows }));
if (!path.isAbsolute(target)) { if (!path.isAbsolute(target)) {
console.log(`Warning: denying request to non-absolute path '${target}'`);
return callback(); return callback();
} }
if (!target.startsWith(userDataPath) && !target.startsWith(installPath)) { if (!target.startsWith(userDataPath) && !target.startsWith(installPath)) {
console.log(`Warning: denying request to ${target}`); console.log(`Warning: denying request to path '${target}'`);
return callback(); return callback();
} }