mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

New getRecentStoryReplies function to clean up replies in multiple convos

Browse source
This commit is contained in:
Scott Nonnenberg 2023-07-21 15:10:32 -07:00 • committed by GitHub
parent ca84d637ae
commit 716f852970
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 356 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

46
ts/test-node/sql_migrations_test.ts
View file

@ -3528,4 +3528,50 @@ describe('SQL migrations test', () => {
assert.isAtLeast(object.createdAt, startingTime);
});
});
describe('updateToSchemaVersion86', () => {
it('supports the right index for first query used in getRecentStoryRepliesSync', () => {
updateToVersion(86);
const [query, params] = sql`
EXPLAIN QUERY PLAN
SELECT json FROM messages WHERE
('messageId' IS NULL OR id IS NOT 'messageId') AND
isStory IS 0 AND
storyId IS 'storyId' AND
received_at = 100000 AND sent_at < 100000
ORDER BY received_at DESC, sent_at DESC
LIMIT 100
`;
const { detail } = db.prepare(query).get(params);
assert.notInclude(detail, 'B-TREE');
assert.notInclude(detail, 'SCAN');
assert.include(
detail,
'SEARCH messages USING INDEX messages_story_replies (storyId=? AND received_at=? AND sent_at<?)'
);
});
it('supports the right index for second query used in getRecentStoryRepliesSync', () => {
updateToVersion(86);
const [query, params] = sql`
EXPLAIN QUERY PLAN
SELECT json FROM messages WHERE
('messageId' IS NULL OR id IS NOT 'messageId') AND
isStory IS 0 AND
storyId IS 'storyId' AND
received_at < 100000
ORDER BY received_at DESC, sent_at DESC
LIMIT 100
`;
const { detail } = db.prepare(query).get(params);
assert.notInclude(detail, 'B-TREE');
assert.notInclude(detail, 'SCAN');
assert.include(
detail,
'SEARCH messages USING INDEX messages_story_replies (storyId=? AND received_at<?)'
);
});
});
});