This commit is contained in:
commit
7099524776
1 changed files with 4 additions and 3 deletions
|
@ -205,10 +205,11 @@ So you wanna make a pull request? Please observe the following guidelines.
|
||||||
to aid in the review process.
|
to aid in the review process.
|
||||||
- Provide a well written and nicely formatted commit message. See [this
|
- Provide a well written and nicely formatted commit message. See [this
|
||||||
link](http://chris.beams.io/posts/git-commit/)
|
link](http://chris.beams.io/posts/git-commit/)
|
||||||
for some tips on formatting. As far as content, try to include in your
|
for some tips on formatting. As far as content, try to include the following in your
|
||||||
summary
|
summary:
|
||||||
|
|
||||||
1. What you changed
|
1. What you changed
|
||||||
2. Why this change was made (including git issue # if appropriate)
|
2. Why this change was made. If there is a relevant [GitHub Issue](https://github.com/signalapp/Signal-Desktop/issues), please include the Issue number.
|
||||||
3. Any relevant technical details or motivations for your implementation
|
3. Any relevant technical details or motivations for your implementation
|
||||||
choices that may be helpful to someone reviewing or auditing the commit
|
choices that may be helpful to someone reviewing or auditing the commit
|
||||||
history in the future. When in doubt, err on the side of a longer
|
history in the future. When in doubt, err on the side of a longer
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue