mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Conversation.onReadMessage - queue job, don't send read receipts

Browse source 
We queue the job because we often get a whole lot of read receipts at
once, and their markRead calls could very easily overlap given the async
pull from DB.

We also disable read receipts for any message marked read due to a read
receipt. That's a notification explosion we don't need.

FREEBIE
This commit is contained in:
Scott Nonnenberg 2017-06-07 12:06:23 -07:00
parent 89046484ed
commit 6fbdd63e7e
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
js/models/conversations.js
View file

@ -71,7 +71,15 @@
// the desktop app, so the desktop app only gets read receipts, we can very
// easily end up with messages never marked as read (our previous early read
// receipt handling, read receipts never sent because app was offline)
return this.markRead(message.get('received_at'));
// We queue it because we often get a whole lot of read receipts at once, and
// their markRead calls could very easily overlap given the async pull from DB.
// Lastly, we don't send read receipts for any message marked read due to a read
// receipt. That's a notification explosion we don't need.
this.queueJob(function() {
return this.markRead(message.get('received_at'), {sendReadReceipts: false});
}.bind(this));
},
getUnread: function() {
@ -293,7 +301,10 @@
}
},
markRead: function(newestUnreadDate) {
markRead: function(newestUnreadDate, options) {
options = options || {};
_.defaults(options, {sendReadReceipts: true});
if (this.get('unreadCount') > 0) {
var conversationId = this.id;
Whisper.Notifications.remove(Whisper.Notifications.where({
@ -323,8 +334,10 @@
var unreadCount = unreadMessages.length - read.length;
this.save({ unreadCount: unreadCount });
console.log('Sending', read.length, 'read receipts');
textsecure.messaging.syncReadMessages(read);
if (options.sendReadReceipts) {
console.log('Sending', read.length, 'read receipts');
textsecure.messaging.syncReadMessages(read);
}
}
}.bind(this));
}