mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use stable keys for rendering timeline

Browse source
This commit is contained in:
Fedor Indutny 2021-08-17 11:41:12 -07:00 committed by GitHub
parent 4a6d28e118
commit 6dcceb81ac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ts/components/conversation/Timeline.tsx
View file

@ -680,6 +680,7 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
const typingBubbleRow = this.getTypingBubbleRow();
let rowContents: ReactNode;
let stableKey = key;
if (haveOldest && row === 0) {
rowContents = (
<div data-row={row} style={styleWithWidth} role="row">
@ -725,6 +726,7 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
);
}
const messageId = items[itemIndex];
stableKey = messageId;
rowContents = (
<div
@ -745,7 +747,7 @@ export class Timeline extends React.PureComponent<PropsType, StateType> {
<CellMeasurer
cache={this.cellSizeCache}
columnIndex={0}
key={key}
key={stableKey}
parent={parent}
rowIndex={index}
width={this.mostRecentWidth}