diff --git a/ts/models/messages.ts b/ts/models/messages.ts index db90d45a1..8c82ebea8 100644 --- a/ts/models/messages.ts +++ b/ts/models/messages.ts @@ -2367,7 +2367,6 @@ export class MessageModel extends window.Backbone.Model { return modifyTargetMessage(this, conversation, { isFirstRun, skipEdits: false, - skipSave: false, }); } diff --git a/ts/util/handleEditMessage.ts b/ts/util/handleEditMessage.ts index 2f9f8b2f4..6708e5698 100644 --- a/ts/util/handleEditMessage.ts +++ b/ts/util/handleEditMessage.ts @@ -342,7 +342,6 @@ export async function handleEditMessage( await modifyTargetMessage(mainMessageModel, mainMessageConversation, { isFirstRun: false, skipEdits: true, - skipSave: true, }); } diff --git a/ts/util/modifyTargetMessage.ts b/ts/util/modifyTargetMessage.ts index 680341437..104f2bb35 100644 --- a/ts/util/modifyTargetMessage.ts +++ b/ts/util/modifyTargetMessage.ts @@ -35,13 +35,9 @@ import { strictAssert } from './assert'; export async function modifyTargetMessage( message: MessageModel, conversation: ConversationModel, - options?: { isFirstRun: boolean; skipEdits: boolean; skipSave: boolean } + options?: { isFirstRun: boolean; skipEdits: boolean } ): Promise { - const { - isFirstRun = false, - skipEdits = false, - skipSave = false, - } = options ?? {}; + const { isFirstRun = false, skipEdits = false } = options ?? {}; const logId = `modifyTargetMessage/${message.idForLogging()}`; const type = message.get('type'); @@ -267,7 +263,7 @@ export async function modifyTargetMessage( ); } - if (!skipSave && changed && !isFirstRun) { + if (changed && !isFirstRun) { log.info(`${logId}: Changes in second run; saving.`); await window.Signal.Data.saveMessage(message.attributes, { ourAci,