Add "all" tab to ReactionViewer

This commit is contained in:
Ken Powers 2020-02-05 18:14:25 -05:00 committed by GitHub
parent c6a23ff4f6
commit 6a9d8b86d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 69 additions and 27 deletions

View file

@ -2190,5 +2190,9 @@
"Reactions--error": { "Reactions--error": {
"message": "Failed to send reaction. Please try again.", "message": "Failed to send reaction. Please try again.",
"description": "Shown when a reaction fails to send" "description": "Shown when a reaction fails to send"
},
"ReactionsViewer--all": {
"message": "All",
"description": "Shown in reaction viewer as the title for the 'all' category"
} }
} }

View file

@ -4871,7 +4871,7 @@ button.module-image__border-overlay:focus {
&__header { &__header {
width: 100%; width: 100%;
min-height: 44px; min-height: 44px;
padding: 0px 16px; padding: 0px 8px;
display: flex; display: flex;
flex-direction: row; flex-direction: row;
justify-content: flex-start; justify-content: flex-start;
@ -4879,14 +4879,15 @@ button.module-image__border-overlay:focus {
overflow-x: auto; overflow-x: auto;
&__button { &__button {
min-width: 45px;
min-height: 28px; min-height: 28px;
border: none; border: none;
border-radius: 18px; border-radius: 18px;
padding: 0px; padding: 0px 8px;
display: flex; display: flex;
justify-content: center; justify-content: center;
align-items: center; align-items: center;
flex-basis: 45px;
flex-shrink: 0;
&:not(:first-of-type) { &:not(:first-of-type) {
margin-left: 4px; margin-left: 4px;
@ -4913,9 +4914,11 @@ button.module-image__border-overlay:focus {
} }
} }
&__count { &__count,
&__all {
@include font-body-2-bold(); @include font-body-2-bold();
margin-left: 2px;
white-space: nowrap;
@include light-theme() { @include light-theme() {
color: $color-gray-90; color: $color-gray-90;
@ -4925,6 +4928,10 @@ button.module-image__border-overlay:focus {
color: $color-gray-05; color: $color-gray-05;
} }
} }
&__count {
margin-left: 4px;
}
} }
} }
@ -4934,19 +4941,25 @@ button.module-image__border-overlay:focus {
overflow: auto; overflow: auto;
&__row { &__row {
margin-top: 8px; margin-top: 12px;
min-height: 32px; min-height: 32px;
display: flex; display: flex;
flex-direction: row; flex-direction: row;
justify-content: flex-start; justify-content: flex-start;
align-items: center; align-items: center;
&:last-of-type {
margin-bottom: 12px;
}
&__avatar { &__avatar {
min-width: 32px; min-width: 32px;
flex-shrink: 1;
} }
&__name { &__name {
@include font-body-1-bold(); @include font-body-1-bold();
flex-grow: 1;
margin-left: 8px; margin-left: 8px;
white-space: nowrap; white-space: nowrap;
overflow: hidden; overflow: hidden;
@ -4960,6 +4973,11 @@ button.module-image__border-overlay:focus {
color: $color-gray-05; color: $color-gray-05;
} }
} }
&__emoji {
width: 18px;
flex-shrink: 1;
}
} }
} }
} }

View file

@ -37,8 +37,7 @@ export const ReactionViewer = React.forwardRef<HTMLDivElement, Props>(
const grouped = mapValues(groupBy(reactions, 'emoji'), res => const grouped = mapValues(groupBy(reactions, 'emoji'), res =>
orderBy(res, ['timestamp'], ['desc']) orderBy(res, ['timestamp'], ['desc'])
); );
const filtered = emojisOrder.filter(e => Boolean(grouped[e])); const [selected, setSelected] = React.useState('all');
const [selected, setSelected] = React.useState(filtered[0]);
const focusRef = React.useRef<HTMLButtonElement>(null); const focusRef = React.useRef<HTMLButtonElement>(null);
// Handle escape key // Handle escape key
@ -65,7 +64,7 @@ export const ReactionViewer = React.forwardRef<HTMLDivElement, Props>(
const emojiSet = new Set<string>(); const emojiSet = new Set<string>();
reactions.forEach(re => emojiSet.add(re.emoji)); reactions.forEach(re => emojiSet.add(re.emoji));
return sortBy(Array.from(emojiSet), emoji => { const arr = sortBy(Array.from(emojiSet), emoji => {
const idx = emojisOrder.indexOf(emoji); const idx = emojisOrder.indexOf(emoji);
if (idx > -1) { if (idx > -1) {
return idx; return idx;
@ -73,6 +72,12 @@ export const ReactionViewer = React.forwardRef<HTMLDivElement, Props>(
return Infinity; return Infinity;
}); });
return ['all', ...arr];
}, [reactions]);
const allSorted = React.useMemo(() => {
return sortBy(reactions, 'timestamp');
}, [reactions]); }, [reactions]);
// If we have previously selected a reaction type that is no longer present // If we have previously selected a reaction type that is no longer present
@ -90,36 +95,46 @@ export const ReactionViewer = React.forwardRef<HTMLDivElement, Props>(
} }
}, [grouped, onClose, renderedEmojis, selected, setSelected]); }, [grouped, onClose, renderedEmojis, selected, setSelected]);
const selectedReactions = grouped[selected] || []; const selectedReactions = grouped[selected] || allSorted;
return ( return (
<div {...rest} ref={ref} className="module-reaction-viewer"> <div {...rest} ref={ref} className="module-reaction-viewer">
<header className="module-reaction-viewer__header"> <header className="module-reaction-viewer__header">
{renderedEmojis {...renderedEmojis
.filter(e => Boolean(grouped[e])) .filter(e => e === 'all' || Boolean(grouped[e]))
.map((emoji, index) => { .map((cat, index) => {
const re = grouped[emoji]; const re = grouped[cat] || reactions;
const maybeFocusRef = index === 0 ? focusRef : undefined; const maybeFocusRef = index === 0 ? focusRef : undefined;
const isAll = cat === 'all';
return ( return (
<button <button
key={emoji} key={cat}
ref={maybeFocusRef} ref={maybeFocusRef}
className={classNames( className={classNames(
'module-reaction-viewer__header__button', 'module-reaction-viewer__header__button',
selected === emoji selected === cat
? 'module-reaction-viewer__header__button--selected' ? 'module-reaction-viewer__header__button--selected'
: null : null
)} )}
onClick={event => { onClick={event => {
event.stopPropagation(); event.stopPropagation();
setSelected(emoji); setSelected(cat);
}} }}
> >
<Emoji size={18} emoji={emoji} /> {isAll ? (
<span className="module-reaction-viewer__header__button__count"> <span className="module-reaction-viewer__header__button__all">
{re.length} {i18n('ReactionsViewer--all')}&thinsp;&middot;&thinsp;
</span> {re.length}
</span>
) : (
<>
<Emoji size={18} emoji={cat} />
<span className="module-reaction-viewer__header__button__count">
{re.length}
</span>
</>
)}
</button> </button>
); );
})} })}
@ -141,12 +156,17 @@ export const ReactionViewer = React.forwardRef<HTMLDivElement, Props>(
i18n={i18n} i18n={i18n}
/> />
</div> </div>
<ContactName <div className="module-reaction-viewer__body__row__name">
module="module-reaction-viewer__body__row__name" <ContactName
name={from.name} module="module-reaction-viewer__body__row__name__contact-name"
profileName={from.profileName} name={from.name}
phoneNumber={from.phoneNumber} profileName={from.profileName}
/> phoneNumber={from.phoneNumber}
/>
</div>
<div className="module-reaction-viewer__body__row__emoji">
<Emoji size={18} emoji={emoji} />
</div>
</div> </div>
))} ))}
</main> </main>