Dont show speaking indicator for active speaker in speaker view
This commit is contained in:
parent
2f691f3dd0
commit
67e290ea8d
6 changed files with 18 additions and 3 deletions
|
@ -105,7 +105,17 @@ const createActiveGroupCallProp = (overrideProps: GroupCallOverrideProps) => ({
|
||||||
peekedParticipants:
|
peekedParticipants:
|
||||||
overrideProps.peekedParticipants || overrideProps.remoteParticipants || [],
|
overrideProps.peekedParticipants || overrideProps.remoteParticipants || [],
|
||||||
remoteParticipants: overrideProps.remoteParticipants || [],
|
remoteParticipants: overrideProps.remoteParticipants || [],
|
||||||
remoteAudioLevels: new Map<number, number>(),
|
remoteAudioLevels: new Map<number, number>(
|
||||||
|
overrideProps.remoteParticipants?.map((_participant, index) => [
|
||||||
|
index,
|
||||||
|
number('remoteAudioLevel', 0, {
|
||||||
|
range: true,
|
||||||
|
min: 0,
|
||||||
|
max: 1,
|
||||||
|
step: 0.01,
|
||||||
|
}),
|
||||||
|
])
|
||||||
|
),
|
||||||
});
|
});
|
||||||
|
|
||||||
const createActiveCallProp = (
|
const createActiveCallProp = (
|
||||||
|
|
|
@ -172,6 +172,7 @@ export function CallingPipRemoteVideo({
|
||||||
isInPip
|
isInPip
|
||||||
remoteParticipant={activeGroupCallSpeaker}
|
remoteParticipant={activeGroupCallSpeaker}
|
||||||
remoteParticipantsCount={activeCall.remoteParticipants.length}
|
remoteParticipantsCount={activeCall.remoteParticipants.length}
|
||||||
|
isActiveSpeakerInSpeakerView={false}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
|
|
@ -126,6 +126,7 @@ export function GroupCallOverflowArea({
|
||||||
)}
|
)}
|
||||||
remoteParticipant={remoteParticipant}
|
remoteParticipant={remoteParticipant}
|
||||||
remoteParticipantsCount={remoteParticipantsCount}
|
remoteParticipantsCount={remoteParticipantsCount}
|
||||||
|
isActiveSpeakerInSpeakerView={false}
|
||||||
/>
|
/>
|
||||||
))}
|
))}
|
||||||
</div>
|
</div>
|
||||||
|
|
|
@ -64,6 +64,7 @@ const createProps = (
|
||||||
}),
|
}),
|
||||||
},
|
},
|
||||||
remoteParticipantsCount: 1,
|
remoteParticipantsCount: 1,
|
||||||
|
isActiveSpeakerInSpeakerView: false,
|
||||||
...overrideProps,
|
...overrideProps,
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
@ -35,6 +35,7 @@ type BasePropsType = {
|
||||||
getFrameBuffer: () => Buffer;
|
getFrameBuffer: () => Buffer;
|
||||||
getGroupCallVideoFrameSource: (demuxId: number) => VideoFrameSource;
|
getGroupCallVideoFrameSource: (demuxId: number) => VideoFrameSource;
|
||||||
i18n: LocalizerType;
|
i18n: LocalizerType;
|
||||||
|
isActiveSpeakerInSpeakerView: boolean;
|
||||||
onVisibilityChanged?: (demuxId: number, isVisible: boolean) => unknown;
|
onVisibilityChanged?: (demuxId: number, isVisible: boolean) => unknown;
|
||||||
remoteParticipant: GroupCallRemoteParticipantType;
|
remoteParticipant: GroupCallRemoteParticipantType;
|
||||||
remoteParticipantsCount: number;
|
remoteParticipantsCount: number;
|
||||||
|
@ -67,6 +68,7 @@ export const GroupCallRemoteParticipant: React.FC<PropsType> = React.memo(
|
||||||
i18n,
|
i18n,
|
||||||
onVisibilityChanged,
|
onVisibilityChanged,
|
||||||
remoteParticipantsCount,
|
remoteParticipantsCount,
|
||||||
|
isActiveSpeakerInSpeakerView,
|
||||||
} = props;
|
} = props;
|
||||||
|
|
||||||
const {
|
const {
|
||||||
|
@ -83,7 +85,6 @@ export const GroupCallRemoteParticipant: React.FC<PropsType> = React.memo(
|
||||||
sharingScreen,
|
sharingScreen,
|
||||||
title,
|
title,
|
||||||
videoAspectRatio,
|
videoAspectRatio,
|
||||||
presenting,
|
|
||||||
} = props.remoteParticipant;
|
} = props.remoteParticipant;
|
||||||
|
|
||||||
const isSpeaking = useValueAtFixedRate(
|
const isSpeaking = useValueAtFixedRate(
|
||||||
|
@ -281,7 +282,7 @@ export const GroupCallRemoteParticipant: React.FC<PropsType> = React.memo(
|
||||||
className={classNames(
|
className={classNames(
|
||||||
'module-ongoing-call__group-call-remote-participant',
|
'module-ongoing-call__group-call-remote-participant',
|
||||||
isSpeaking &&
|
isSpeaking &&
|
||||||
!presenting &&
|
!isActiveSpeakerInSpeakerView &&
|
||||||
remoteParticipantsCount > 1 &&
|
remoteParticipantsCount > 1 &&
|
||||||
'module-ongoing-call__group-call-remote-participant--speaking'
|
'module-ongoing-call__group-call-remote-participant--speaking'
|
||||||
)}
|
)}
|
||||||
|
|
|
@ -296,6 +296,7 @@ export function GroupCallRemoteParticipants({
|
||||||
top={top}
|
top={top}
|
||||||
width={renderedWidth}
|
width={renderedWidth}
|
||||||
remoteParticipantsCount={remoteParticipants.length}
|
remoteParticipantsCount={remoteParticipants.length}
|
||||||
|
isActiveSpeakerInSpeakerView={isInSpeakerView}
|
||||||
/>
|
/>
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue