Fix failover on failed sends, and improve logging

ts/background.ts

@@ -1772,7 +1772,9 @@ export async function startApp(): Promise<void> {
         } catch (error) {
           log.error(
             'connect: Error refreshing remote config:',
-            Errors.toLogFormat(error)
+            isNumber(error.code)
+              ? `code: ${error.code}`
+              : Errors.toLogFormat(error)
           );
         }
       }

ts/services/profiles.ts

@@ -3,6 +3,7 @@
 
 import type { ProfileKeyCredentialRequestContext } from '@signalapp/libsignal-client/zkgroup';
 import PQueue from 'p-queue';
+import { isNumber } from 'lodash';
 
 import type { ConversationModel } from '../models/conversations';
 import type {
@@ -496,7 +497,9 @@ async function doGetProfile(c: ConversationModel): Promise<void> {
         log.warn(
           'getProfile failure:',
           idForLogging,
-          Errors.toLogFormat(error)
+          isNumber(error.code)
+            ? `code: ${error.code}`
+            : Errors.toLogFormat(error)
         );
         return;
     }

ts/textsecure/OutgoingMessage.ts

@@ -539,9 +539,12 @@ export default class OutgoingMessage {
             },
             async (error: Error) => {
               if (
-                error instanceof HTTPError &&
+                error instanceof SendMessageNetworkError &&
                 (error.code === 401 || error.code === 403)
               ) {
+                log.warn(
+                  `OutgoingMessage.doSendMessage: Failing over to unsealed send for identifier ${identifier}`
+                );
                 if (this.failoverIdentifiers.indexOf(identifier) === -1) {
                   this.failoverIdentifiers.push(identifier);
                 }

ts/util/sendToGroup.ts

@@ -843,7 +843,14 @@ export function _shouldFailSend(error: unknown, logId: string): boolean {
 
   if (error instanceof SendMessageProtoError) {
     if (!error.errors || !error.errors.length) {
-      logError('SendMessageProtoError had no errors, failing.');
+      logError('SendMessageProtoError had no errors but was thrown! Failing.');
+      return true;
+    }
+
+    if (error.successfulIdentifiers && error.successfulIdentifiers.length > 0) {
+      logError(
+        'SendMessageProtoError had successful sends; no further sends needed. Failing.'
+      );
       return true;
     }