From 60a478d8bdb28fc62b98b75296ce5f03839043e3 Mon Sep 17 00:00:00 2001
From: automated-signal <37887102+automated-signal@users.noreply.github.com>
Date: Thu, 29 Feb 2024 20:02:29 -0600
Subject: [PATCH] Fix i18n numbers getting toString()'d

Co-authored-by: Jamie Kyle <113370520+jamiebuilds-signal@users.noreply.github.com>
---
 ts/components/CallParticipantCount.tsx          | 6 +++---
 ts/components/CallingAdhocCallInfo.tsx          | 2 +-
 ts/components/CallingParticipantsList.tsx       | 2 +-
 ts/components/CallingPreCallInfo.tsx            | 6 +++---
 ts/components/conversation/GroupV1Migration.tsx | 2 +-
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/ts/components/CallParticipantCount.tsx b/ts/components/CallParticipantCount.tsx
index 52fc5213fa..21440f3874 100644
--- a/ts/components/CallParticipantCount.tsx
+++ b/ts/components/CallParticipantCount.tsx
@@ -37,7 +37,7 @@ export function CallParticipantCount({
   }
   if (!innerText) {
     innerText = i18n('icu:CallControls__InfoDisplay--participants', {
-      count: String(count),
+      count,
     });
   }
 
@@ -46,7 +46,7 @@ export function CallParticipantCount({
     return (
       <span
         aria-label={i18n('icu:calling__participants', {
-          people: String(count),
+          people: count,
         })}
         className="CallControls__Status--InactiveCallParticipantCount"
       >
@@ -58,7 +58,7 @@ export function CallParticipantCount({
   return (
     <button
       aria-label={i18n('icu:calling__participants', {
-        people: String(count),
+        people: count,
       })}
       className="CallControls__Status--ParticipantCount"
       onClick={toggleParticipants}
diff --git a/ts/components/CallingAdhocCallInfo.tsx b/ts/components/CallingAdhocCallInfo.tsx
index a68eabb788..8d9cf41f6e 100644
--- a/ts/components/CallingAdhocCallInfo.tsx
+++ b/ts/components/CallingAdhocCallInfo.tsx
@@ -59,7 +59,7 @@ export function CallingAdhocCallInfo({
               i18n('icu:calling__in-this-call--one')}
             {participants.length > 1 &&
               i18n('icu:calling__in-this-call--many', {
-                people: String(participants.length),
+                people: participants.length,
               })}
           </div>
           <button
diff --git a/ts/components/CallingParticipantsList.tsx b/ts/components/CallingParticipantsList.tsx
index 551df60e8a..af1eb731c1 100644
--- a/ts/components/CallingParticipantsList.tsx
+++ b/ts/components/CallingParticipantsList.tsx
@@ -88,7 +88,7 @@ export const CallingParticipantsList = React.memo(
                   i18n('icu:calling__in-this-call--one')}
                 {participants.length > 1 &&
                   i18n('icu:calling__in-this-call--many', {
-                    people: String(participants.length),
+                    people: participants.length,
                   })}
               </div>
               <button
diff --git a/ts/components/CallingPreCallInfo.tsx b/ts/components/CallingPreCallInfo.tsx
index 5c0a55ea5b..2242dba429 100644
--- a/ts/components/CallingPreCallInfo.tsx
+++ b/ts/components/CallingPreCallInfo.tsx
@@ -104,7 +104,7 @@ export function CallingPreCallInfo({
         subtitle = i18n('icu:calling__pre-call-info--many-people-in-call', {
           first: participantNames[0],
           second: participantNames[1],
-          others: String(participantNames.length - 2),
+          others: participantNames.length - 2,
         });
         break;
     }
@@ -171,12 +171,12 @@ export function CallingPreCallInfo({
           ? i18n('icu:calling__pre-call-info--will-ring-many', {
               first: memberNames[0],
               second: memberNames[1],
-              others: String(memberNames.length - 2),
+              others: memberNames.length - 2,
             })
           : i18n('icu:calling__pre-call-info--will-notify-many', {
               first: memberNames[0],
               second: memberNames[1],
-              others: String(memberNames.length - 2),
+              others: memberNames.length - 2,
             });
         break;
       }
diff --git a/ts/components/conversation/GroupV1Migration.tsx b/ts/components/conversation/GroupV1Migration.tsx
index d2621027f4..ed2a337855 100644
--- a/ts/components/conversation/GroupV1Migration.tsx
+++ b/ts/components/conversation/GroupV1Migration.tsx
@@ -126,7 +126,7 @@ function renderUsers(
     );
   }
 
-  const count = members.length.toString();
+  const count = members.length;
 
   return (
     <p>