Add new eslint plugin to check for valid i18n keys

This commit is contained in:
Jamie Kyle 2023-01-05 14:43:33 -08:00 committed by GitHub
parent 465b4cb0fb
commit 569b6e14a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
39 changed files with 447 additions and 78 deletions

View file

@ -75,20 +75,24 @@ export class GroupNotification extends React.Component<Props> {
throw new Error('Group update is missing contacts');
}
// eslint-disable-next-line no-case-declarations
const otherPeopleNotifMsg =
otherPeople.length === 1
? 'joinedTheGroup'
: 'multipleJoinedTheGroup';
return (
<>
{otherPeople.length > 0 && (
<Intl
i18n={i18n}
id={otherPeopleNotifMsg}
components={[otherPeopleWithCommas]}
/>
<>
{otherPeople.length === 1 ? (
<Intl
i18n={i18n}
id="joinedTheGroup"
components={[otherPeopleWithCommas]}
/>
) : (
<Intl
i18n={i18n}
id="multipleJoinedTheGroup"
components={[otherPeopleWithCommas]}
/>
)}
</>
)}
{contactsIncludesMe && (
<div className="module-group-notification__change">
@ -106,12 +110,18 @@ export class GroupNotification extends React.Component<Props> {
throw new Error('Group update is missing contacts');
}
// eslint-disable-next-line no-case-declarations
const leftKey =
contacts.length > 1 ? 'multipleLeftTheGroup' : 'leftTheGroup';
return (
<Intl i18n={i18n} id={leftKey} components={[otherPeopleWithCommas]} />
return contacts.length > 1 ? (
<Intl
id="multipleLeftTheGroup"
i18n={i18n}
components={[otherPeopleWithCommas]}
/>
) : (
<Intl
id="leftTheGroup"
i18n={i18n}
components={[otherPeopleWithCommas]}
/>
);
case 'general':
return;