mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Improve conversion between typed arrays

Browse source
This commit is contained in:
Fedor Indutny 2022-02-22 17:05:53 -08:00 • committed by GitHub
parent 5d035dff86
commit 5453d10572
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ts/Crypto.ts
View file

@ -35,7 +35,12 @@ export type EncryptedAttachment = {
// Generate a number between zero and 16383 // Generate a number between zero and 16383
export function generateRegistrationId(): number { export function generateRegistrationId(): number {
const id = new Uint16Array(getRandomBytes(2))[0]; const bytes = getRandomBytes(2);
const id = new Uint16Array(
bytes.buffer,
bytes.byteOffset,
bytes.byteLength / 2
)[0];
// eslint-disable-next-line no-bitwise // eslint-disable-next-line no-bitwise
return id & 0x3fff; return id & 0x3fff;

6
ts/test-electron/Crypto_test.ts
View file

@ -165,12 +165,18 @@ describe('Crypto', () => {
describe('generateRegistrationId', () => { describe('generateRegistrationId', () => {
it('generates an integer between 0 and 16383 (inclusive)', () => { it('generates an integer between 0 and 16383 (inclusive)', () => {
let max = 0;
for (let i = 0; i < 100; i += 1) { for (let i = 0; i < 100; i += 1) {
const id = generateRegistrationId(); const id = generateRegistrationId();
assert.isAtLeast(id, 0); assert.isAtLeast(id, 0);
assert.isAtMost(id, 16383); assert.isAtMost(id, 16383);
assert(Number.isInteger(id)); assert(Number.isInteger(id));
max = Math.max(max, id);
} }
// Probability of this being false is ~ 10^{-181}
assert.isAtLeast(max, 0x100);
}); });
}); });