mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Make 1 the minimum registration ID

Browse source
This commit is contained in:
Evan Hahn 2022-10-05 16:35:56 +00:00 • committed by GitHub
parent e20ec013f5
commit 5219cdf2c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 30 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

18
ts/test-electron/Crypto_test.ts
View file

@ -25,6 +25,7 @@ import {
decryptSymmetric,
hmacSha256,
verifyHmacSha256,
randomInt,
uuidToBytes,
bytesToUuid,
} from '../Crypto';
@ -164,11 +165,11 @@ describe('Crypto', () => {
});
describe('generateRegistrationId', () => {
it('generates an integer between 0 and 16383 (inclusive)', () => {
let max = 0;
it('generates an integer between 1 and 16383 (inclusive)', () => {
let max = -1;
for (let i = 0; i < 100; i += 1) {
const id = generateRegistrationId();
assert.isAtLeast(id, 0);
assert.isAtLeast(id, 1);
assert.isAtMost(id, 16383);
assert(Number.isInteger(id));
@ -441,6 +442,17 @@ describe('Crypto', () => {
});
});
describe('randomInt', () => {
it('returns random integers in a range (inclusive)', () => {
const seen = new Set<number>();
for (let i = 0; i < 1_000_000 || seen.size < 3; i += 1) {
seen.add(randomInt(1, 3));
}
assert.deepStrictEqual(seen, new Set([1, 2, 3]));
});
});
describe('uuidToBytes', () => {
it('converts valid UUIDs to Uint8Arrays', () => {
const expectedResult = new Uint8Array([