mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix call link refresh on CallLinkUpdate sync for metadata changes

Browse source 
Co-authored-by: ayumi-signal <143036029+ayumi-signal@users.noreply.github.com>
This commit is contained in:
automated-signal 2025-07-29 16:39:39 -05:00 • committed by GitHub
parent 1bb4bc370c
commit 515ba94c1c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

32
ts/state/ducks/calling.ts
View file

@ -1608,26 +1608,24 @@ function handleCallLinkUpdate(
};
const result = await DataWriter.insertOrUpdateCallLinkFromSync(callLink);
const { inserted, updated, callLink: resultCallLink } = result;
if (result.inserted) {
log.info(`${logId}: Saved new call link`);
} else if (result.updated) {
log.info(`${logId}: Updated existing call link with new adminKey`);
} else {
// This case happens when concurrently processing a batch of call link sync messages
// for the same roomId.
log.info(
`${logId}: Discarding call link update because we are already up to date`
);
return;
// Sync messages only include rootKey and adminKey. We will update a record here
// if another device tells us of the adminKey. If other info has changed,
// we need to fetch the call link from the server with callLinkRefreshJobQueue.
if (inserted || updated) {
if (inserted) {
log.info(`${logId}: Saved new call link`);
} else {
log.info(`${logId}: Updated existing call link with new adminKey`);
}
dispatch({
type: HANDLE_CALL_LINK_UPDATE,
payload: { callLink: resultCallLink },
});
}
dispatch({
type: HANDLE_CALL_LINK_UPDATE,
payload: { callLink: result.callLink },
});
const isPlaceholderCallHistoryNeeded = result.inserted && adminKey != null;
const isPlaceholderCallHistoryNeeded = inserted && adminKey != null;
if (isPlaceholderCallHistoryNeeded) {
const callHistory = toCallHistoryFromUnusedCallLink(callLink);
await DataWriter.saveCallHistory(callHistory);