Message Send Log: Increase retention length

ts/background.ts

@@ -1030,9 +1030,24 @@ export async function startApp(): Promise<void> {
       const now = Date.now();
       const HOUR = 1000 * 60 * 60;
       const DAY = 24 * HOUR;
-      const oneDayAgo = now - DAY;
+      let sentProtoMaxAge = 14 * DAY;
+
       try {
-        await window.Signal.Data.deleteSentProtosOlderThan(oneDayAgo);
+        sentProtoMaxAge = parseIntOrThrow(
+          window.Signal.RemoteConfig.getValue('desktop.retryRespondMaxAge'),
+          'retryRespondMaxAge'
+        );
+      } catch (error) {
+        window.log.warn(
+          'background/setInterval: Failed to parse integer from desktop.retryRespondMaxAge feature flag',
+          error && error.stack ? error.stack : error
+        );
+      }
+
+      try {
+        await window.Signal.Data.deleteSentProtosOlderThan(
+          now - sentProtoMaxAge
+        );
       } catch (error) {
         window.log.error(
           'background/onready/setInterval: Error deleting sent protos: ',

ts/models/conversations.ts

@@ -1203,7 +1203,10 @@ export class ConversationModel extends window.Backbone
 
       const { ContentHint } = Proto.UnidentifiedSenderMessage.Message;
 
-      const sendOptions = await getSendOptions(this.attributes);
+      const sendOptions = {
+        ...(await getSendOptions(this.attributes)),
+        online: true,
+      };
       if (isDirectConversation(this.attributes)) {
         handleMessageSend(
           window.textsecure.messaging.sendMessageProtoAndWait({
@@ -1212,10 +1215,7 @@ export class ConversationModel extends window.Backbone
             proto: contentMessage,
             contentHint: ContentHint.IMPLICIT,
             groupId: undefined,
-            options: {
+            options: sendOptions,
-              ...sendOptions,
-              online: true,
-            },
           }),
           { messageIds: [], sendType: 'typing' }
         );

ts/textsecure/SendMessage.ts

@@ -1882,12 +1882,12 @@ export default class MessageSender {
     const ourUuid = window.textsecure.storage.user.getUuid();
     if (!ourUuid) {
       throw new Error(
-        'sendSenderKeyDistributionMessage: Failed to fetch our UUID!'
+        'getSenderKeyDistributionMessage: Failed to fetch our UUID!'
       );
     }
     const ourDeviceId = parseIntOrThrow(
       window.textsecure.storage.user.getDeviceId(),
-      'sendSenderKeyDistributionMessage'
+      'getSenderKeyDistributionMessage'
     );
 
     const protocolAddress = ProtocolAddress.new(ourUuid, ourDeviceId);

ts/util/handleRetry.ts

@@ -56,8 +56,8 @@ export async function onRetryRequest(event: RetryRequestEvent): Promise<void> {
   }
 
   const HOUR = 60 * 60 * 1000;
-  const ONE_DAY = 24 * HOUR;
+  const DAY = 24 * HOUR;
-  let retryRespondMaxAge = ONE_DAY;
+  let retryRespondMaxAge = 14 * DAY;
   try {
     retryRespondMaxAge = parseIntOrThrow(
       RemoteConfig.getValue('desktop.retryRespondMaxAge'),