mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Group Details: Show unregistered users in member list

Browse source
This commit is contained in:
Scott Nonnenberg 2021-07-28 11:52:49 -07:00 • committed by GitHub
parent e7a2365905
commit 4b92e12f83
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/test-both/util/getGroupMemberships_test.ts
View file

@ -57,7 +57,7 @@ describe('getGroupMemberships', () => {
assert.isEmpty(result); assert.isEmpty(result);
}); });
it('filters out unregistered conversations', () => { it('does not filter out unregistered conversations', () => {
const conversation = { const conversation = {
memberships: [ memberships: [
{ {
@ -70,7 +70,11 @@ describe('getGroupMemberships', () => {
const result = getGroupMemberships(conversation, getConversationById) const result = getGroupMemberships(conversation, getConversationById)
.memberships; .memberships;
assert.isEmpty(result); assert.lengthOf(result, 1);
assert.deepEqual(result[0], {
isAdmin: true,
member: unregisteredConversation,
});
}); });
it('hydrates memberships', () => { it('hydrates memberships', () => {

2
ts/util/getGroupMemberships.ts
View file

@ -29,7 +29,7 @@ export const getGroupMemberships = (
memberships: memberships.reduce( memberships: memberships.reduce(
(result: Array<GroupV2Membership>, membership) => { (result: Array<GroupV2Membership>, membership) => {
const member = getConversationById(membership.conversationId); const member = getConversationById(membership.conversationId);
if (!member || isConversationUnregistered(member)) { if (!member) {
return result; return result;
} }
return [...result, { isAdmin: membership.isAdmin, member }]; return [...result, { isAdmin: membership.isAdmin, member }];