Some PNP fixes

This commit is contained in:
Fedor Indutny 2024-02-16 14:01:06 -08:00 committed by GitHub
parent 41e44a8787
commit 499ee6c956
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 17 additions and 13 deletions

View file

@ -2439,7 +2439,7 @@
"description": "Error message when you try to send an edit after message becomes too old" "description": "Error message when you try to send an edit after message becomes too old"
}, },
"icu:startConversation--username-not-found": { "icu:startConversation--username-not-found": {
"messageformat": "User not found. {atUsername} is not a Signal user; make sure youve entered the complete username.", "messageformat": "{atUsername} is not a Signal user. Make sure you've entered the complete username.",
"description": "Shown in dialog if username is not found. Note that 'username' will be the output of at-username" "description": "Shown in dialog if username is not found. Note that 'username' will be the output of at-username"
}, },
"icu:startConversation--phone-number-not-found": { "icu:startConversation--phone-number-not-found": {

View file

@ -625,17 +625,18 @@ export function LeftPane({
dialogs.push({ key: 'banner', dialog: maybeBanner }); dialogs.push({ key: 'banner', dialog: maybeBanner });
} }
const hideHeader =
modeSpecificProps.mode === LeftPaneMode.Archive ||
modeSpecificProps.mode === LeftPaneMode.Compose ||
modeSpecificProps.mode === LeftPaneMode.FindByUsername ||
modeSpecificProps.mode === LeftPaneMode.FindByPhoneNumber ||
modeSpecificProps.mode === LeftPaneMode.ChooseGroupMembers ||
modeSpecificProps.mode === LeftPaneMode.SetGroupMetadata;
return ( return (
<NavSidebar <NavSidebar
title="Chats" title="Chats"
hideHeader={ hideHeader={hideHeader}
modeSpecificProps.mode === LeftPaneMode.Archive ||
modeSpecificProps.mode === LeftPaneMode.Compose ||
modeSpecificProps.mode === LeftPaneMode.FindByUsername ||
modeSpecificProps.mode === LeftPaneMode.FindByPhoneNumber ||
modeSpecificProps.mode === LeftPaneMode.ChooseGroupMembers ||
modeSpecificProps.mode === LeftPaneMode.SetGroupMetadata
}
i18n={i18n} i18n={i18n}
otherTabsUnreadStats={otherTabsUnreadStats} otherTabsUnreadStats={otherTabsUnreadStats}
hasFailedStorySends={hasFailedStorySends} hasFailedStorySends={hasFailedStorySends}
@ -722,9 +723,10 @@ export function LeftPane({
</NavSidebarSearchHeader> </NavSidebarSearchHeader>
)} )}
<div className="module-left-pane__dialogs"> <div className="module-left-pane__dialogs">
{dialogs.map(({ key, dialog }) => ( {!hideHeader &&
<React.Fragment key={key}>{dialog}</React.Fragment> dialogs.map(({ key, dialog }) => (
))} <React.Fragment key={key}>{dialog}</React.Fragment>
))}
</div> </div>
{preRowsNode && <React.Fragment key={0}>{preRowsNode}</React.Fragment>} {preRowsNode && <React.Fragment key={0}>{preRowsNode}</React.Fragment>}
<div className="module-left-pane__list--measure" ref={measureRef}> <div className="module-left-pane__list--measure" ref={measureRef}>

View file

@ -621,6 +621,8 @@ export function ProfileEditor({
} }
label={i18n('icu:ProfileEditor__username-link')} label={i18n('icu:ProfileEditor__username-link')}
onClick={() => { onClick={() => {
markCompletedUsernameLinkOnboarding();
if (usernameLinkCorrupted) { if (usernameLinkCorrupted) {
setIsResettingUsernameLink(true); setIsResettingUsernameLink(true);
return; return;
@ -633,7 +635,7 @@ export function ProfileEditor({
/> />
); );
if (!hasCompletedUsernameLinkOnboarding) { if (!hasCompletedUsernameLinkOnboarding && !usernameLink) {
maybeUsernameLinkRow = ( maybeUsernameLinkRow = (
<UsernameLinkTooltip <UsernameLinkTooltip
handleClose={markCompletedUsernameLinkOnboarding} handleClose={markCompletedUsernameLinkOnboarding}