Fix quote styles so they are uniform
This commit is contained in:
parent
8a765da6a3
commit
48aaf9e4f3
5 changed files with 3 additions and 43 deletions
|
@ -1442,23 +1442,17 @@ $timer-icons: '55', '50', '45', '40', '35', '30', '25', '20', '15', '10', '05',
|
||||||
margin: {
|
margin: {
|
||||||
left: -6px;
|
left: -6px;
|
||||||
right: -6px;
|
right: -6px;
|
||||||
top: -4px;
|
top: 3px;
|
||||||
bottom: 5px;
|
bottom: 5px;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
.module-quote-container--with-content-above {
|
|
||||||
margin-top: 3px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.module-quote {
|
.module-quote {
|
||||||
@include button-reset;
|
@include button-reset;
|
||||||
width: 100%;
|
width: 100%;
|
||||||
|
|
||||||
position: relative;
|
position: relative;
|
||||||
border-radius: 4px;
|
border-radius: 4px;
|
||||||
border-top-left-radius: 10px;
|
|
||||||
border-top-right-radius: 10px;
|
|
||||||
|
|
||||||
display: flex;
|
display: flex;
|
||||||
flex-direction: row;
|
flex-direction: row;
|
||||||
|
@ -1479,11 +1473,6 @@ $timer-icons: '55', '50', '45', '40', '35', '30', '25', '20', '15', '10', '05',
|
||||||
cursor: auto;
|
cursor: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
.module-quote--with-content-above {
|
|
||||||
border-top-left-radius: 4px;
|
|
||||||
border-top-right-radius: 4px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.module-quote--with-reference-warning {
|
.module-quote--with-reference-warning {
|
||||||
border-bottom-left-radius: 0px;
|
border-bottom-left-radius: 0px;
|
||||||
border-bottom-right-radius: 0px;
|
border-bottom-right-radius: 0px;
|
||||||
|
@ -1492,6 +1481,7 @@ $timer-icons: '55', '50', '45', '40', '35', '30', '25', '20', '15', '10', '05',
|
||||||
.module-quote--outgoing {
|
.module-quote--outgoing {
|
||||||
border-left-color: $color-steel;
|
border-left-color: $color-steel;
|
||||||
background-color: $color-steel;
|
background-color: $color-steel;
|
||||||
|
margin-top: -4px;
|
||||||
|
|
||||||
// To preserve contrast
|
// To preserve contrast
|
||||||
@include keyboard-mode {
|
@include keyboard-mode {
|
||||||
|
|
|
@ -578,7 +578,6 @@ export const CompositionArea = ({
|
||||||
// and this is for conversation_view.
|
// and this is for conversation_view.
|
||||||
clearQuotedMessage();
|
clearQuotedMessage();
|
||||||
}}
|
}}
|
||||||
withContentAbove
|
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
|
@ -1061,7 +1061,6 @@ export class Message extends React.PureComponent<Props, State> {
|
||||||
public renderQuote(): JSX.Element | null {
|
public renderQuote(): JSX.Element | null {
|
||||||
const {
|
const {
|
||||||
conversationColor,
|
conversationColor,
|
||||||
conversationType,
|
|
||||||
customColor,
|
customColor,
|
||||||
direction,
|
direction,
|
||||||
disableScroll,
|
disableScroll,
|
||||||
|
@ -1076,8 +1075,6 @@ export class Message extends React.PureComponent<Props, State> {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
const withContentAbove =
|
|
||||||
conversationType === 'group' && direction === 'incoming';
|
|
||||||
const { isViewOnce, referencedMessageNotFound } = quote;
|
const { isViewOnce, referencedMessageNotFound } = quote;
|
||||||
|
|
||||||
const clickHandler = disableScroll
|
const clickHandler = disableScroll
|
||||||
|
@ -1103,7 +1100,6 @@ export class Message extends React.PureComponent<Props, State> {
|
||||||
isViewOnce={isViewOnce}
|
isViewOnce={isViewOnce}
|
||||||
referencedMessageNotFound={referencedMessageNotFound}
|
referencedMessageNotFound={referencedMessageNotFound}
|
||||||
isFromMe={quote.isFromMe}
|
isFromMe={quote.isFromMe}
|
||||||
withContentAbove={withContentAbove}
|
|
||||||
doubleCheckMissingQuoteReference={() =>
|
doubleCheckMissingQuoteReference={() =>
|
||||||
doubleCheckMissingQuoteReference(id)
|
doubleCheckMissingQuoteReference(id)
|
||||||
}
|
}
|
||||||
|
|
|
@ -145,10 +145,6 @@ const createProps = (overrideProps: Partial<Props> = {}): Props => ({
|
||||||
? overrideProps.text
|
? overrideProps.text
|
||||||
: 'A sample message from a pal'
|
: 'A sample message from a pal'
|
||||||
),
|
),
|
||||||
withContentAbove: boolean(
|
|
||||||
'withContentAbove',
|
|
||||||
overrideProps.withContentAbove || false
|
|
||||||
),
|
|
||||||
});
|
});
|
||||||
|
|
||||||
story.add('Outgoing by Another Author', () => {
|
story.add('Outgoing by Another Author', () => {
|
||||||
|
@ -196,19 +192,6 @@ story.add('Incoming/Outgoing Colors', () => {
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
story.add('Content Above', () => {
|
|
||||||
const props = createProps({
|
|
||||||
withContentAbove: true,
|
|
||||||
});
|
|
||||||
|
|
||||||
return (
|
|
||||||
<>
|
|
||||||
<div>Content Above</div>
|
|
||||||
<Quote {...props} />
|
|
||||||
</>
|
|
||||||
);
|
|
||||||
});
|
|
||||||
|
|
||||||
story.add('Image Only', () => {
|
story.add('Image Only', () => {
|
||||||
const props = createProps({
|
const props = createProps({
|
||||||
text: '',
|
text: '',
|
||||||
|
|
|
@ -23,7 +23,6 @@ export type Props = {
|
||||||
i18n: LocalizerType;
|
i18n: LocalizerType;
|
||||||
isFromMe: boolean;
|
isFromMe: boolean;
|
||||||
isIncoming?: boolean;
|
isIncoming?: boolean;
|
||||||
withContentAbove: boolean;
|
|
||||||
onClick?: () => void;
|
onClick?: () => void;
|
||||||
onClose?: () => void;
|
onClose?: () => void;
|
||||||
text: string;
|
text: string;
|
||||||
|
@ -440,7 +439,6 @@ export class Quote extends React.Component<Props, State> {
|
||||||
isIncoming,
|
isIncoming,
|
||||||
onClick,
|
onClick,
|
||||||
referencedMessageNotFound,
|
referencedMessageNotFound,
|
||||||
withContentAbove,
|
|
||||||
} = this.props;
|
} = this.props;
|
||||||
|
|
||||||
if (!validateQuote(this.props)) {
|
if (!validateQuote(this.props)) {
|
||||||
|
@ -448,12 +446,7 @@ export class Quote extends React.Component<Props, State> {
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div className="module-quote-container">
|
||||||
className={classNames(
|
|
||||||
'module-quote-container',
|
|
||||||
withContentAbove ? 'module-quote-container--with-content-above' : null
|
|
||||||
)}
|
|
||||||
>
|
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
onClick={this.handleClick}
|
onClick={this.handleClick}
|
||||||
|
@ -465,7 +458,6 @@ export class Quote extends React.Component<Props, State> {
|
||||||
? `module-quote--incoming-${conversationColor}`
|
? `module-quote--incoming-${conversationColor}`
|
||||||
: `module-quote--outgoing-${conversationColor}`,
|
: `module-quote--outgoing-${conversationColor}`,
|
||||||
!onClick ? 'module-quote--no-click' : null,
|
!onClick ? 'module-quote--no-click' : null,
|
||||||
withContentAbove ? 'module-quote--with-content-above' : null,
|
|
||||||
referencedMessageNotFound
|
referencedMessageNotFound
|
||||||
? 'module-quote--with-reference-warning'
|
? 'module-quote--with-reference-warning'
|
||||||
: null
|
: null
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue