mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Handle 409/410 when confirming username

Browse source
This commit is contained in:
Fedor Indutny 2023-02-14 09:39:47 -08:00 • committed by GitHub
parent 10885e5d3f
commit 486ada8b6c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 106 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

42
ts/test-electron/state/ducks/username_test.ts
View file

@ -20,7 +20,10 @@ import { actions } from '../../../state/ducks/username';
import { ToastType } from '../../../types/Toast';
import { noopAction } from '../../../state/ducks/noop';
import { reducer } from '../../../state/reducer';
import { ReserveUsernameError } from '../../../types/Username';
import {
ReserveUsernameError,
ConfirmUsernameResult,
} from '../../../types/Username';
const DEFAULT_RESERVATION = {
username: 'abc.12',
@ -312,7 +315,7 @@ describe('electron/state/ducks/username', () => {
describe('confirmUsername', () => {
it('should dispatch promise when reservation is present', () => {
const doConfirmUsername = sinon.stub().resolves();
const doConfirmUsername = sinon.stub().resolves(ConfirmUsernameResult.Ok);
const dispatch = sinon.spy();
actions.confirmUsername({
@ -344,7 +347,7 @@ describe('electron/state/ducks/username', () => {
state = reducer(state, {
type: 'username/CONFIRM_USERNAME_FULFILLED',
payload: undefined,
payload: ConfirmUsernameResult.Ok,
meta: undefined,
});
@ -389,6 +392,39 @@ describe('electron/state/ducks/username', () => {
UsernameReservationError.General
);
});
it('should not close modal on "conflict or gone"', () => {
let state = stateWithReservation;
state = reducer(state, {
type: 'username/CONFIRM_USERNAME_PENDING',
meta: undefined,
});
assert.strictEqual(
getUsernameReservationState(state),
UsernameReservationState.Confirming
);
assert.strictEqual(
getUsernameReservationObject(state),
DEFAULT_RESERVATION
);
state = reducer(state, {
type: 'username/CONFIRM_USERNAME_FULFILLED',
payload: ConfirmUsernameResult.ConflictOrGone,
meta: undefined,
});
assert.strictEqual(
getUsernameReservationState(state),
UsernameReservationState.Open
);
assert.strictEqual(getUsernameReservationObject(state), undefined);
assert.strictEqual(
getUsernameReservationError(state),
UsernameReservationError.ConflictOrGone
);
});
});
describe('deleteUsername', () => {