Debug log optimizations and improvements

app/global_errors.js

@@ -3,6 +3,7 @@ const electron = require('electron');
 const Errors = require('../js/modules/types/errors');
 
 const { app, dialog, clipboard } = electron;
+const { redactAll } = require('../js/modules/privacy');
 
 // We're using hard-coded strings in this file because it needs to be ready
 //   to report errors before we do anything in the app. Also, we expect users to directly
@@ -23,7 +24,7 @@ function handleError(prefix, error) {
     });
 
     if (buttonIndex === 1) {
-      clipboard.writeText(`${prefix}\n${error.stack}`);
+      clipboard.writeText(`${prefix}\n${redactAll(error.stack)}`);
     }
   } else {
     dialog.showErrorBox(prefix, error.stack);

app/logging.js

@@ -12,6 +12,8 @@ const readFirstLine = require('firstline');
 const readLastLines = require('read-last-lines').read;
 const rimraf = require('rimraf');
 
+const { redactAll } = require('../js/modules/privacy');
+
 const { app, ipcMain: ipc } = electron;
 const LEVELS = ['fatal', 'error', 'warn', 'info', 'debug', 'trace'];
 let logger;
@@ -247,7 +249,7 @@ function logAtLevel(level, ...args) {
 
       return item;
     });
-    logger[level](str.join(' '));
+    logger[level](redactAll(str.join(' ')));
   } else {
     console._log(...args);
   }

js/modules/backup.js

@@ -1204,7 +1204,6 @@ function createTempDir() {
 }
 
 function deleteAll(pattern) {
-  window.log.info(`Deleting ${pattern}`);
   return pify(rimraf)(pattern);
 }
 

libtextsecure/message_receiver.js

@@ -588,9 +588,7 @@ MessageReceiver.prototype.extend({
 
     return promise.catch(error => {
       window.log.error(
-        'queueDecryptedEnvelope error handling envelope',
-        id,
-        ':',
+        `queueDecryptedEnvelope error handling envelope ${id}:`,
         error && error.stack ? error.stack : error
       );
     });