diff --git a/ts/components/conversation/conversation-details/ConversationDetails.stories.tsx b/ts/components/conversation/conversation-details/ConversationDetails.stories.tsx index 76a66a3b8e..ced797c770 100644 --- a/ts/components/conversation/conversation-details/ConversationDetails.stories.tsx +++ b/ts/components/conversation/conversation-details/ConversationDetails.stories.tsx @@ -68,8 +68,8 @@ const createProps = (hasGroupLink = false): Props => ({ updateGroupAttributes: async () => { action('updateGroupAttributes')(); }, - onBlockAndDelete: action('onBlockAndDelete'), - onDelete: action('onDelete'), + onBlock: action('onBlock'), + onLeave: action('onLeave'), }); story.add('Basic', () => { diff --git a/ts/components/conversation/conversation-details/ConversationDetails.tsx b/ts/components/conversation/conversation-details/ConversationDetails.tsx index 3f39dfedcb..f06c600612 100644 --- a/ts/components/conversation/conversation-details/ConversationDetails.tsx +++ b/ts/components/conversation/conversation-details/ConversationDetails.tsx @@ -55,8 +55,8 @@ export type StateProps = { title?: string; }> ) => Promise; - onBlockAndDelete: () => void; - onDelete: () => void; + onBlock: () => void; + onLeave: () => void; }; export type Props = StateProps; @@ -78,8 +78,8 @@ export const ConversationDetails: React.ComponentType = ({ showPendingInvites, showLightboxForMedia, updateGroupAttributes, - onBlockAndDelete, - onDelete, + onBlock, + onLeave, }) => { const [modalState, setModalState] = useState( ModalState.NothingOpen @@ -301,8 +301,8 @@ export const ConversationDetails: React.ComponentType = ({ i18n={i18n} cannotLeaveBecauseYouAreLastAdmin={cannotLeaveBecauseYouAreLastAdmin} conversationTitle={conversation.title} - onDelete={onDelete} - onBlockAndDelete={onBlockAndDelete} + onLeave={onLeave} + onBlock={onBlock} /> {modalNode} diff --git a/ts/components/conversation/conversation-details/ConversationDetailsActions.stories.tsx b/ts/components/conversation/conversation-details/ConversationDetailsActions.stories.tsx index 023dbe2dda..2e5f5d5aaf 100644 --- a/ts/components/conversation/conversation-details/ConversationDetailsActions.stories.tsx +++ b/ts/components/conversation/conversation-details/ConversationDetailsActions.stories.tsx @@ -28,8 +28,8 @@ const createProps = (overrideProps: Partial = {}): Props => ({ ? overrideProps.cannotLeaveBecauseYouAreLastAdmin : false, conversationTitle: overrideProps.conversationTitle || '', - onBlockAndDelete: action('onBlockAndDelete'), - onDelete: action('onDelete'), + onBlock: action('onBlock'), + onLeave: action('onLeave'), i18n, }); diff --git a/ts/components/conversation/conversation-details/ConversationDetailsActions.tsx b/ts/components/conversation/conversation-details/ConversationDetailsActions.tsx index cecbad1a87..356a3c75b4 100644 --- a/ts/components/conversation/conversation-details/ConversationDetailsActions.tsx +++ b/ts/components/conversation/conversation-details/ConversationDetailsActions.tsx @@ -15,16 +15,16 @@ import { ConversationDetailsIcon } from './ConversationDetailsIcon'; export type Props = { cannotLeaveBecauseYouAreLastAdmin: boolean; conversationTitle: string; - onBlockAndDelete: () => void; - onDelete: () => void; + onBlock: () => void; + onLeave: () => void; i18n: LocalizerType; }; export const ConversationDetailsActions: React.ComponentType = ({ cannotLeaveBecauseYouAreLastAdmin, conversationTitle, - onBlockAndDelete, - onDelete, + onBlock, + onLeave, i18n, }) => { const [confirmingLeave, setConfirmingLeave] = React.useState(false); @@ -94,7 +94,7 @@ export const ConversationDetailsActions: React.ComponentType = ({ text: i18n( 'ConversationDetailsActions--leave-group-modal-confirm' ), - action: onDelete, + action: onLeave, style: 'affirmative', }, ]} @@ -113,7 +113,7 @@ export const ConversationDetailsActions: React.ComponentType = ({ text: i18n( 'ConversationDetailsActions--block-group-modal-confirm' ), - action: onBlockAndDelete, + action: onBlock, style: 'affirmative', }, ]} diff --git a/ts/state/smart/ConversationDetails.tsx b/ts/state/smart/ConversationDetails.tsx index eba4a45392..2b2125077a 100644 --- a/ts/state/smart/ConversationDetails.tsx +++ b/ts/state/smart/ConversationDetails.tsx @@ -36,8 +36,8 @@ export type SmartConversationDetailsProps = { title?: string; }> ) => Promise; - onBlockAndDelete: () => void; - onDelete: () => void; + onBlock: () => void; + onLeave: () => void; }; const mapStateToProps = ( diff --git a/ts/views/conversation_view.ts b/ts/views/conversation_view.ts index 68c568aa52..13f2f2f7f2 100644 --- a/ts/views/conversation_view.ts +++ b/ts/views/conversation_view.ts @@ -3067,22 +3067,19 @@ Whisper.ConversationView = Whisper.View.extend({ // these methods are used in more than one place and should probably be // dried up and hoisted to methods on ConversationView - const onDelete = () => { + const onLeave = () => { this.longRunningTaskWrapper({ - name: 'onDelete', - task: this.model.syncMessageRequestResponse.bind( - this.model, - messageRequestEnum.DELETE - ), + name: 'onLeave', + task: () => this.model.leaveGroupV2(), }); }; - const onBlockAndDelete = () => { + const onBlock = () => { this.longRunningTaskWrapper({ - name: 'onBlockAndDelete', + name: 'onBlock', task: this.model.syncMessageRequestResponse.bind( this.model, - messageRequestEnum.BLOCK_AND_DELETE + messageRequestEnum.BLOCK ), }); }; @@ -3110,8 +3107,8 @@ Whisper.ConversationView = Whisper.View.extend({ updateGroupAttributes: conversation.updateGroupAttributesV2.bind( conversation ), - onDelete, - onBlockAndDelete, + onLeave, + onBlock, }; const view = new Whisper.ReactWrapperView({