Update safety number verification messages to match ios/android

_locales/en/messages.json

@@ -571,10 +571,20 @@
     "description": "Label for a button to accept a new safety number"
   },
   "verify": {
-    "message": "Mark as verified"
+    "message": "Mark as verified",
+    "description": "(deleted 2023/02/03)"
   },
   "unverify": {
-    "message": "Mark as not verified"
+    "message": "Mark as not verified",
+    "description": "(deleted 2023/02/03)"
+  },
+  "icu:SafetyNumberViewer__markAsVerified": {
+    "messageformat": "Mark as verified",
+    "description": "Safety number viewer, verification toggle button, when not verified, sets verified"
+  },
+  "icu:SafetyNumberViewer__clearVerification": {
+    "messageformat": "Clear verification",
+    "description": "Safety number viewer, verification toggle button, when verified, clears verification state"
   },
   "isVerified": {
     "message": "You have verified your safety number with $name$.",
@@ -1149,6 +1159,10 @@
   "showSafetyNumber": {
     "message": "View safety number"
   },
+  "icu:ContactModal__showSafetyNumber": {
+    "messageformat": "View safety number",
+    "description": "Contact modal, label for button to show safety number modal"
+  },
   "viewRecentMedia": {
     "message": "View recent media",
     "description": "This is a menu item for viewing all media (images + video) in a conversation, using the imperative case, as in a command."
@@ -1974,7 +1988,15 @@
   },
   "verifyNewNumber": {
     "message": "Verify Safety Number",
-    "description": "Label on button included with safety number change notification in the conversation"
+    "description": "(deleted 2023/02/03) Label on button included with safety number change notification in the conversation"
+  },
+  "icu:ConversationDetails__viewSafetyNumber": {
+    "messageformat": "View Safety Number",
+    "description": "In conversation details, label for button to view safety number, opens safety number modal"
+  },
+  "icu:SafetyNumberNotification__viewSafetyNumber": {
+    "messageformat": "View Safety Number",
+    "description": "In conversation, safety number change notification, label for button to view safety number, opens safety number modal"
   },
   "cannotGenerateSafetyNumber": {
     "message": "This user can't be verified until you've exchanged messages with them.",

ts/components/SafetyNumberViewer.tsx

@@ -64,7 +64,9 @@ export function SafetyNumberViewer({
   );
 
   const { isVerified } = contact;
-  const verifyButtonText = isVerified ? i18n('unverify') : i18n('verify');
+  const verifyButtonText = isVerified
+    ? i18n('icu:SafetyNumberViewer__clearVerification')
+    : i18n('icu:SafetyNumberViewer__markAsVerified');
 
   return (
     <div className="module-SafetyNumberViewer">
@@ -78,7 +80,6 @@ export function SafetyNumberViewer({
         ) : (
           <span className="module-SafetyNumberViewer__icon--shield" />
         )}
-        {}
         {isVerified ? (
           <Intl i18n={i18n} id="isVerified" components={[boldName]} />
         ) : (

ts/components/conversation/SafetyNumberNotification.tsx

@@ -68,7 +68,7 @@ export function SafetyNumberNotification({
           size={ButtonSize.Small}
           variant={ButtonVariant.SystemMessage}
         >
-          {i18n('verifyNewNumber')}
+          {i18n('icu:SafetyNumberNotification__viewSafetyNumber')}
         </Button>
       }
     />

ts/components/conversation/conversation-details/ConversationDetails.tsx

@@ -482,13 +482,13 @@ export function ConversationDetails({
             onClick={() => toggleSafetyNumberModal(conversation.id)}
             icon={
               <ConversationDetailsIcon
-                ariaLabel={i18n('verifyNewNumber')}
+                ariaLabel={i18n('icu:ConversationDetails__viewSafetyNumber')}
                 icon={IconType.verify}
               />
             }
             label={
               <div className="ConversationDetails__safety-number">
-                {i18n('verifyNewNumber')}
+                {i18n('icu:ConversationDetails__viewSafetyNumber')}
               </div>
             }
           />