mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Enable crash reporting for all channels

Browse source
This commit is contained in:
Scott Nonnenberg 2024-03-29 09:41:19 -07:00 • committed by GitHub
parent aa5208ac24
commit 32223acf5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

22
app/crashReports.ts
View file

@ -9,7 +9,6 @@ import z from 'zod';
import type { LoggerType } from '../ts/types/Logging'; import type { LoggerType } from '../ts/types/Logging';
import * as Errors from '../ts/types/errors'; import * as Errors from '../ts/types/errors';
import { isProduction } from '../ts/util/version';
import OS from '../ts/util/os/osMain'; import OS from '../ts/util/os/osMain';
const dumpSchema = z const dumpSchema = z
@ -65,21 +64,12 @@ async function eraseDumps(
export function setup( export function setup(
getLogger: () => LoggerType, getLogger: () => LoggerType,
showDebugLogWindow: () => Promise<void>, showDebugLogWindow: () => Promise<void>
forceEnable = false
): void { ): void {
const isEnabled = !isProduction(app.getVersion()) || forceEnable; getLogger().info('crashReporter: enabled');
if (isEnabled) {
getLogger().info(`crashReporter: ${forceEnable ? 'force ' : ''}enabled`);
crashReporter.start({ uploadToServer: false }); crashReporter.start({ uploadToServer: false });
}
ipc.handle('crash-reports:get-count', async () => { ipc.handle('crash-reports:get-count', async () => {
if (!isEnabled) {
return 0;
}
const pendingDumps = await getPendingDumps(); const pendingDumps = await getPendingDumps();
if (pendingDumps.length !== 0) { if (pendingDumps.length !== 0) {
getLogger().warn( getLogger().warn(
@ -90,10 +80,6 @@ export function setup(
}); });
ipc.handle('crash-reports:write-to-log', async () => { ipc.handle('crash-reports:write-to-log', async () => {
if (!isEnabled) {
return;
}
const pendingDumps = await getPendingDumps(); const pendingDumps = await getPendingDumps();
if (pendingDumps.length === 0) { if (pendingDumps.length === 0) {
return; return;
@ -133,10 +119,6 @@ export function setup(
}); });
ipc.handle('crash-reports:erase', async () => { ipc.handle('crash-reports:erase', async () => {
if (!isEnabled) {
return;
}
const pendingDumps = await getPendingDumps(); const pendingDumps = await getPendingDumps();
await eraseDumps(getLogger(), pendingDumps); await eraseDumps(getLogger(), pendingDumps);

6
app/main.ts
View file

@ -207,13 +207,9 @@ const defaultWebPrefs = {
const DISABLE_GPU = const DISABLE_GPU =
OS.isLinux() && !process.argv.some(arg => arg === '--enable-gpu'); OS.isLinux() && !process.argv.some(arg => arg === '--enable-gpu');
const FORCE_ENABLE_CRASH_REPORTS = process.argv.some(
arg => arg === '--enable-crash-reports'
);
const CLI_LANG = cliOptions.lang as string | undefined; const CLI_LANG = cliOptions.lang as string | undefined;
setupCrashReports(getLogger, showDebugLogWindow, FORCE_ENABLE_CRASH_REPORTS); setupCrashReports(getLogger, showDebugLogWindow);
let sendDummyKeystroke: undefined | (() => void); let sendDummyKeystroke: undefined | (() => void);
if (OS.isWindows()) { if (OS.isWindows()) {