mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Fix lightbox for tap-to-view GIFs

Browse source
This commit is contained in:
Fedor Indutny 2021-09-02 14:38:46 -07:00 • committed by GitHub
parent ddc591e962
commit 30075f18fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 38 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

30
ts/components/Lightbox.tsx
View file

@ -170,22 +170,29 @@ export function Lightbox({
};
}, [onKeyDown]);
const { attachment, contentType, loop = false, objectURL, message } =
media[selectedIndex] || {};
const isAttachmentGIF = isGIF([attachment]);
useEffect(() => {
playVideo();
if (videoElement && isViewOnce) {
videoElement.addEventListener('timeupdate', onTimeUpdate);
return () => {
videoElement.removeEventListener('timeupdate', onTimeUpdate);
};
if (!videoElement || !isViewOnce) {
return noop;
}
return noop;
}, [isViewOnce, onTimeUpdate, playVideo, videoElement]);
if (isAttachmentGIF) {
return noop;
}
videoElement.addEventListener('timeupdate', onTimeUpdate);
return () => {
videoElement.removeEventListener('timeupdate', onTimeUpdate);
};
}, [isViewOnce, isAttachmentGIF, onTimeUpdate, playVideo, videoElement]);
const { attachment, contentType, loop = false, objectURL, message } =
media[selectedIndex] || {};
const caption = attachment?.caption;
let content: JSX.Element;
@ -239,7 +246,8 @@ export function Lightbox({
);
}
} else if (isVideoTypeSupported) {
const shouldLoop = loop || isGIF([attachment]) || isViewOnce;
const shouldLoop = loop || isAttachmentGIF || isViewOnce;
content = (
<video
className="Lightbox__object"