mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Use utility & fixup dependency array

Browse source
This commit is contained in:
trevor-signal 2023-12-22 15:51:27 -05:00
parent ef67a98c20
commit 2ff0d87309
2 changed files with 19 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

34
ts/components/Lightbox.tsx
View file

@ -26,6 +26,7 @@ import { isGIF } from '../types/Attachment';
import { useRestoreFocus } from '../hooks/useRestoreFocus'; import { useRestoreFocus } from '../hooks/useRestoreFocus';
import { usePrevious } from '../hooks/usePrevious'; import { usePrevious } from '../hooks/usePrevious';
import { arrow } from '../util/keyboard'; import { arrow } from '../util/keyboard';
import { isCmdOrCtrl } from '../hooks/useKeyboardShortcuts';
export type PropsType = { export type PropsType = {
children?: ReactNode; children?: ReactNode;
@ -160,21 +161,24 @@ export function Lightbox({
setVideoTime(videoElement.currentTime); setVideoTime(videoElement.currentTime);
}, [setVideoTime, videoElement]); }, [setVideoTime, videoElement]);
const handleSave = ( const handleSave = useCallback(
event: KeyboardEvent | React.MouseEvent<HTMLButtonElement, MouseEvent> (
) => { event: KeyboardEvent | React.MouseEvent<HTMLButtonElement, MouseEvent>
if (isViewOnce) { ) => {
return; if (isViewOnce) {
} return;
}
event.stopPropagation(); event.stopPropagation();
event.preventDefault(); event.preventDefault();
const mediaItem = media[selectedIndex]; const mediaItem = media[selectedIndex];
const { attachment, message, index } = mediaItem; const { attachment, message, index } = mediaItem;
saveAttachment(attachment, message.sent_at, index + 1); saveAttachment(attachment, message.sent_at, index + 1);
}; },
[isViewOnce, media, saveAttachment, selectedIndex]
);
const handleForward = ( const handleForward = (
event: React.MouseEvent<HTMLButtonElement, MouseEvent> event: React.MouseEvent<HTMLButtonElement, MouseEvent>
@ -193,8 +197,6 @@ export function Lightbox({
const onKeyDown = useCallback( const onKeyDown = useCallback(
(event: KeyboardEvent) => { (event: KeyboardEvent) => {
const isMacOS = (window.platform === 'darwin');
switch (event.key) { switch (event.key) {
case 'Escape': { case 'Escape': {
closeLightbox(); closeLightbox();
@ -214,8 +216,8 @@ export function Lightbox({
break; break;
case 's': case 's':
if (isMacOS ? event.metaKey : event.ctrlKey) { if (isCmdOrCtrl(event)) {
handleSave(event); handleSave(event);
} }
break; break;

2
ts/hooks/useKeyboardShortcuts.tsx
View file

@ -14,7 +14,7 @@ import type { ContextMenuTriggerType } from '../components/conversation/MessageC
type KeyboardShortcutHandlerType = (ev: KeyboardEvent) => boolean; type KeyboardShortcutHandlerType = (ev: KeyboardEvent) => boolean;
function isCmdOrCtrl(ev: KeyboardEvent): boolean { export function isCmdOrCtrl(ev: KeyboardEvent): boolean {
const { ctrlKey, metaKey } = ev; const { ctrlKey, metaKey } = ev;
const commandKey = get(window, 'platform') === 'darwin' && metaKey; const commandKey = get(window, 'platform') === 'darwin' && metaKey;
const controlKey = get(window, 'platform') !== 'darwin' && ctrlKey; const controlKey = get(window, 'platform') !== 'darwin' && ctrlKey;