mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Change default for keepalive autodisconnect config

Browse source 
By default, automatically disconnect if no response. This is preferable
because we can sometimes lose connectivity without receiving a close
event from the socket, but it's also possible that the endpoint may not
support responses.

// FREEBIE
This commit is contained in:
lilia 2015-07-29 10:51:33 -07:00
parent fdad87b6a0
commit 2b563212b4
3 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
js/libtextsecure.js
View file

@ -38636,7 +38636,7 @@ TextSecureWebSocket = function (url, opts) {
}
this.disconnect = opts.disconnect;
if (this.disconnect === undefined) {
this.disconnect = false;
this.disconnect = true;
}
this.wsr = websocketResource;
this.reset();

12
libtextsecure/test/websocket-resources_test.js
View file

@ -128,8 +128,8 @@
done();
});
});
var resource = new WebSocketResource(new WebSocket('ws://localhost:8081'), {
keepalive: { path: '/v1/keepalive', disconnect: true }
new WebSocketResource(new WebSocket('ws://localhost:8081'), {
keepalive: { path: '/v1/keepalive' }
});
});
@ -145,8 +145,8 @@
done();
});
});
var resource = new WebSocketResource(new WebSocket('ws://localhost:8081'), {
keepalive: { disconnect: true }
new WebSocketResource(new WebSocket('ws://localhost:8081'), {
keepalive: true
});
});
@ -158,9 +158,7 @@
mockServer.on('connection', function(server) {
server.on('close', done);
});
var resource = new WebSocketResource(socket, {
keepalive: { disconnect: true }
});
new WebSocketResource(socket, { keepalive: true });
});
it('allows resetting the keepalive timer', function(done) {

2
libtextsecure/websocket-resources.js
View file

@ -165,7 +165,7 @@
}
this.disconnect = opts.disconnect;
if (this.disconnect === undefined) {
this.disconnect = false;
this.disconnect = true;
}
this.wsr = websocketResource;
this.reset();