From 2a55bfbef93f75f8b40f32a002e06827b15ffe91 Mon Sep 17 00:00:00 2001 From: trevor-signal <131492920+trevor-signal@users.noreply.github.com> Date: Mon, 9 Sep 2024 15:26:21 -0400 Subject: [PATCH] Respond to malformed messages with empty body --- ts/textsecure/MessageReceiver.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ts/textsecure/MessageReceiver.ts b/ts/textsecure/MessageReceiver.ts index e8e1e62d7..0bccb47e2 100644 --- a/ts/textsecure/MessageReceiver.ts +++ b/ts/textsecure/MessageReceiver.ts @@ -407,15 +407,15 @@ export default class MessageReceiver } const job = async () => { - if (!request.body) { - throw new Error( - 'MessageReceiver.handleRequest: request.body was falsey!' - ); - } - - const plaintext = request.body; - try { + if (!request.body) { + throw new Error( + 'MessageReceiver.handleRequest: request.body was falsey!' + ); + } + + const plaintext = request.body; + const decoded = Proto.Envelope.decode(plaintext); const serverTimestamp = decoded.serverTimestamp?.toNumber() ?? 0;