mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Respond to PR feedback

Browse source 
- makeThumbnail -> makeImageThumbnail
- duplicate 'display: flex'
- remove no-longer-applicable comment
This commit is contained in:
Scott Nonnenberg 2018-04-26 09:50:13 -07:00
parent ac0b50d20f
commit 27a30b3267
3 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
js/views/file_input_view.js
View file

@ -28,7 +28,7 @@
template: i18n('unsupportedFileType'),
});
function makeThumbnail(size, objectUrl) {
function makeImageThumbnail(size, objectUrl) {
return new Promise(((resolve, reject) => {
const img = document.createElement('img');
img.onerror = reject;
@ -117,7 +117,7 @@
const arrayBuffer = await blobToArrayBuffer(blob);
const screenshotObjectUrl = makeObjectUrl(arrayBuffer, 'image/png');
return makeThumbnail(size, screenshotObjectUrl);
return makeImageThumbnail(size, screenshotObjectUrl);
}
Whisper.FileInputView = Backbone.View.extend({
@ -354,7 +354,7 @@
const objectUrl = URL.createObjectURL(file);
const arrayBuffer = await makeThumbnail(size, objectUrl);
const arrayBuffer = await makeImageThumbnail(size, objectUrl);
URL.revokeObjectURL(objectUrl);
return this.readFile(arrayBuffer);
@ -447,7 +447,7 @@
},
});
Whisper.FileInputView.makeThumbnail = makeThumbnail;
Whisper.FileInputView.makeImageThumbnail = makeImageThumbnail;
Whisper.FileInputView.makeVideoThumbnail = makeVideoThumbnail;
Whisper.FileInputView.makeVideoScreenshot = makeVideoScreenshot;
}());