mirrors/signal-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 2 Wiki Activity Actions

Update mock tests to use locator.fill instead of .type

Browse source
This commit is contained in:
trevor-signal 2024-04-08 12:58:08 -04:00 • committed by GitHub
parent 09f1c15a3e
commit 2497d0d8a1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
ts/test-mock/helpers.ts
View file

@ -32,14 +32,16 @@ export async function typeIntoInput(
currentValue = (await input.textContent()) ?? '';
}
await input.type(text, { delay: 30 });
const newValue = `${currentValue}${text}`;
await input.fill(newValue);
// Wait to ensure that the input (and react state controlling it) has actually
// updated with the right value
if (isInputElement) {
await expect(input).toHaveValue(`${currentValue}${text}`);
await expect(input).toHaveValue(newValue);
} else {
await input.locator(`:text("${currentValue}${text}")`).waitFor();
await input.locator(`:text("${newValue}")`).waitFor();
}
}

6
ts/test-mock/storage/message_request_test.ts
View file

@ -117,11 +117,7 @@ describe('storage service', function (this: Mocha.Suite) {
}
debug('Enter message text');
const composeArea = window.locator(
'.composition-area-wrapper, .Inbox__conversation .ConversationView'
);
const input = composeArea.locator('[data-testid=CompositionInput]');
const input = await app.waitForEnabledComposer();
await typeIntoInput(input, 'hello stranger!');
await input.press('Enter');