From 24174312b9c2b322af47cf0f7f111a074eb4f286 Mon Sep 17 00:00:00 2001 From: Scott Nonnenberg Date: Fri, 16 Jun 2017 10:46:55 -0700 Subject: [PATCH] Fix: Show attachment views; they trigger update syncrhonously FREEBIE --- js/views/attachment_view.js | 6 +++--- js/views/message_view.js | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/js/views/attachment_view.js b/js/views/attachment_view.js index 3362a63e4c..f596e3dce4 100644 --- a/js/views/attachment_view.js +++ b/js/views/attachment_view.js @@ -208,7 +208,7 @@ this.update(); }, renderFileView: function() { - this.view = new FileView({ + this.fileView = new FileView({ model: { mediaType: this.mediaType(), fileName: this.displayName(), @@ -217,8 +217,8 @@ } }); - this.view.$el.appendTo(this.$el.empty()); - this.view.render(); + this.fileView.$el.appendTo(this.$el.empty()); + this.fileView.render(); return this; }, update: function() { diff --git a/js/views/message_view.js b/js/views/message_view.js index 8c85b150c5..05658b200c 100644 --- a/js/views/message_view.js +++ b/js/views/message_view.js @@ -295,13 +295,14 @@ model: attachment, timestamp: this.model.get('sent_at') }); - view.render(); this.loadedAttachments.push(view); this.listenTo(view, 'update', function() { view.updated = true; this.appendAttachmentView(view); }); + + view.render(); }.bind(this)); } });